1570669 - Peer reflex candidate shows up as (redacted) even if camera/microphone permission granted

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P3)

Description

[Dan Minor [:dminor]]

We don't check to see if camera/microphone permission has been granted before hiding peer reflex candidate ip addresses [1]. We should only be hiding them if address obfuscation is enabled.

[1] https://searchfox.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/MediaTransportHandler.cpp#1137

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1570669 - Only redact peer reflex candidates if host address obfuscation is enabled; r=mjf!

This adds a mObfuscateHostAddresses member and uses it to control whether or
not peer reflex candidates are redacted. It is only necessary to keep track of
signaled addresses to support redacting peer reflex candidates, so there is no
need to store them if host address obfuscation is disabled.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c530832e8866
Only redact peer reflex candidates if host address obfuscation is enabled; r=mjf

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c530832e8866