1570700 - browser.search.get() fails on ubuntu 18.04 FF68.0.1

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[ssborbis]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

browser.search.get() run on ubuntu 18.04 64bit, FF 68.0.1 (debug console, web extension background page, etc )

Actual results:

An unexpected error occured

Expected results:

Promise resolves with array of one-click search engines

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

I need to check on FFx build vs Canonical build, Canonical may be removing it.

Edited: reporter did confirm it's a distro issue.

Comment 2

[ssborbis]

Confirmed it only occurs in the Canonical build. Tarball 68.0.1 works as expected

Comment 3

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Thank you for checking that!

This is always frustrating with distro builds, they may disable features for any number of reasons, which can cause things like this.

One more step, if you have time. Can you install this sample extension on the Canonical build and see if it works or not?

https://github.com/mdn/webextensions-examples/tree/master/menu-search

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Temporary_Installation_in_Firefox

Comment 4

[ssborbis]

Using menu-search as temp add-on

Canonical - fail ( Error: An unexpected error occurred .......... undefined )
Official - works as expected

Comment 5

[Mike Kaply [:mkaply]]

This is working with other distros. Maybe something Snap related?

Comment 6

[ssborbis]

(In reply to Mike Kaply [:mkaply] from comment #5)

This is working with other distros. Maybe something Snap related?

I had an addon user report this bug on ubuntu 18.04 64bit, confirmed on my vbox install. I'll test snap vs apt

Comment 7

[Rob Wu [:robwu]]

Cannot reproduce on Ubuntu 18.04, Firefox 68.0.1 (Canonical, installed via apt, Dutch locale).

If you are able to reproduce, could you check whether the global JavaScript console (Ctrl-Shift-J) contains any errors?

The error could be caused by https://searchfox.org/mozilla-central/rev/b38e3beb658b80e1ed03e0fdf64d225bd4a40327/browser/components/extensions/parent/ext-search.js#56
... when a search engine is defined with a non-existing icon URL.

Comment 8

[Rob Wu [:robwu]]

I went to https://packages.ubuntu.com/bionic/web/firefox
and downloaded the source package from http://archive.ubuntu.com/ubuntu/pool/main/f/firefox/firefox_68.0.1+build1-0ubuntu0.18.04.1.debian.tar.xz

Inside that package, there is debian/searchplugins/amazondotcom.xml (and many other amazon*.xml files). They reference resource://search-plugins/images/amazon.ico.
This file was removed in part 3 of bug 1496075, so any request to fetch that image URL will fail, and hence break browser.search.get.

Comment 9

[ssborbis]

(In reply to Rob Wu [:robwu] from comment #8)

I went to https://packages.ubuntu.com/bionic/web/firefox
and downloaded the source package from http://archive.ubuntu.com/ubuntu/pool/main/f/firefox/firefox_68.0.1+build1-0ubuntu0.18.04.1.debian.tar.xz

Inside that package, there is debian/searchplugins/amazondotcom.xml (and many other amazon*.xml files). They reference resource://search-plugins/images/amazon.ico.
This file was removed in part 3 of bug 1496075, so any request to fetch that image URL will fail, and hence break browser.search.get.

Yep, simply deleting the Amazon engine without an icon fixed the issue. I'll let the user know.

Comment 10

[Rob Wu [:robwu]]

Attachment: Bug 1570700 - Drop support for resource/chrome icons in search engines

All built-in engines have migrated from OpenSearch to WebExtensions.
WebExtensions do not support resource: or chrome:-URLs in their
favicon_url field, so the "resource:" and "chrome:" URLs can only be
used by external opensearch XML files. These should not rely on internal
resources from omni.ja, as the bug shows. So just drop support for
"chrome:" and "resource:"-URLs, as we don't need them any more.

Current OpenSearch engines that relied on chrome/resource:-URLs can
either replace the URL with a data:-URL, or migrate to WebExtensions.

Comment 11

[Rob Wu [:robwu]]

(linking to meta bug 1517486, because the proposed patch removes a feature that is not supported by the WebExtension format)

Comment 12

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Thanks everyone for their help getting to next steps on this bug! Y'all rock. 🙌

Comment 13

[Mike Kaply [:mkaply]]

I'll fix the URLs in the partner distro repository.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/778471f56de7
Drop support for resource/chrome icons in search engines r=mkaply,daleharvey,mixedpuppy

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/778471f56de7

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for uplift or can it ride Fx70 to release?

Comment 17

[Mike Kaply [:mkaply]]

Is this something we should consider for uplift or can it ride Fx70 to release?

Getting it on 69 would be nice, but the Snap problem specifically will be fixed by a change to their distro.

Comment 18

[Rob Wu [:robwu]]

Let's ride the train. The number of users that are affected by this is probably small. A work-aroumd for them is to delete the (opensearch) file/engine.

Comment 19

[Miruna Curtean]

Attachment: console browser search.png

Hello,
I've tried to reproduce this on Ubuntu 18.04.2 LTS 64-bit on Firefox Release 68.0.1 by downloading and temporarily adding in about:debugging the "menu-search" extension manifest from comment 3.
After which debugging mode was enabled, a Debug performed and also I used the the browser.search.get() function in the console.
No error was received; for more details please check the "console browser search" attachment.
If manual QA is still needed on this issue, could you please add the "qe+" verify flag and also provided more steps or details in order to test?
Thank you

Comment 20

[Rob Wu [:robwu]]

There is automated test coverage.