1570715 - Update unit tests to replace headerURL, accentcolor, textcolor

Status: RESOLVED FIXED

(WebExtensions :: Themes, task, P1)

Description

[Rob Wu [:robwu]]

There are a bunch of tests in toolkit/mozapps/extensions/test/xpcshell/ that use the removed headerURL:
https://searchfox.org/mozilla-central/search?q=headerURL&case=false&regexp=false&path=test%2Fxpcshell

The tests themselves just need a theme and don't really care about the effect of the theme, so the absence of headerURL didn't cause the test to fail. I do however see deprecation messages in the console.

It's easy enough to fix those (simply replace headerURL with theme_frame).
I wonder whether we should introduce a (default-on in unit tests) pref to treat deprecation warnings in extensions as errors, to make sure that such issues never happen again.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1570715 - Replace deprecated manifest properties in extension tests

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1570715 - Treat (deprecation) warnings as errors

Add new preference extensions.webextensions.warnings-as-errors that
defaults to true in tests. Tests that expect warnings are modified
to briefly flip the pref for the specific part of the test that needs
an exception.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51824b1dda97
Replace deprecated manifest properties in extension tests r=rpl
https://hg.mozilla.org/integration/autoland/rev/e7364a10a663
Treat (deprecation) warnings as errors r=rpl

Comment 4

[Cosmin Sabou [:CosminS]]

Rob, could you please take a look into these speedometer max run time outs? https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=android%2C7.0%2Cmotog5%2Cpgo%2Craptor%2Cperformance%2Ctests%2Con%2Cfirefox%2Ctest-android-hw-g5-7-0-arm7-api-16%2Fpgo-raptor-speedometer-geckoview-e10s%2Crap%28sp%29&tochange=013bdea4e8e3020016b428e90ac967a08e123bdb&fromchange=4e6dd979ed238a6c0be55ecfb8a42d6ca417d865&selectedJob=266601867
Filed bug 1581223 to track those failures.

Comment 5

[Rob Wu [:robwu]]

I'll take a look. Most likely the raptor extension is using a deprecated API.

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/51824b1dda97
https://hg.mozilla.org/mozilla-central/rev/e7364a10a663

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for causing tp6m raptor failures (Bug 1568050)

Backout link: https://hg.mozilla.org/integration/autoland/rev/72d9ad70e1ba7d56e9e3732cfd912f53c348a9a8
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266548810&repo=autoland&lineNumber=1499

Comment 8

[Rob Wu [:robwu]]

This was going to be fixed by bug 1581223 .

The patch can reland without changes, together with bug 1581223

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/72d9ad70e1ba

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1124b75d02a6
Replace deprecated manifest properties in extension tests r=rpl
https://hg.mozilla.org/integration/autoland/rev/dc3646b4f5a2
Treat (deprecation) warnings as errors r=rpl

Comment 11

[Andrew Erickson [:aerickson]]

The android-hw devices have been using a new image with a newer python2. This started on 9/11 12PM pacific to 9/12 12PM and then has continued from 9/13 5PM pacific onward. The newer python2 may be unoptimized compared to the default py2 on ubuntu. :bobclary questioned if python performance could affect the timing of on-device operations. Let me know if the bisect doesn't reveal anything.

Comment 12

[Rob Wu [:robwu]]

@Andrew I suggest to (re)post that comment at bug 1568050.

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1124b75d02a6
https://hg.mozilla.org/mozilla-central/rev/dc3646b4f5a2

Comment 14

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!