Closed Bug 1570715 Opened 3 months ago Closed 29 days ago

Update unit tests to replace headerURL, accentcolor, textcolor

Categories

(WebExtensions :: Themes, task, P1)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

Details

Attachments

(2 files)

There are a bunch of tests in toolkit/mozapps/extensions/test/xpcshell/ that use the removed headerURL:
https://searchfox.org/mozilla-central/search?q=headerURL&case=false&regexp=false&path=test%2Fxpcshell

The tests themselves just need a theme and don't really care about the effect of the theme, so the absence of headerURL didn't cause the test to fail. I do however see deprecation messages in the console.

It's easy enough to fix those (simply replace headerURL with theme_frame).
I wonder whether we should introduce a (default-on in unit tests) pref to treat deprecation warnings in extensions as errors, to make sure that such issues never happen again.

Add new preference extensions.webextensions.warnings-as-errors that
defaults to true in tests. Tests that expect warnings are modified
to briefly flip the pref for the specific part of the test that needs
an exception.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/51824b1dda97
Replace deprecated manifest properties in extension tests r=rpl
https://hg.mozilla.org/integration/autoland/rev/e7364a10a663
Treat (deprecation) warnings as errors r=rpl
Regressions: 1581223

I'll take a look. Most likely the raptor extension is using a deprecated API.

Flags: needinfo?(rob)
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Regressions: 1568050
No longer regressions: 1568050
Status: RESOLVED → REOPENED
Flags: needinfo?(rob)
Resolution: FIXED → ---
Target Milestone: mozilla71 → ---

This was going to be fixed by bug 1581223 .

The patch can reland without changes, together with bug 1581223

Flags: needinfo?(rob)
Regressions: 1581243
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/1124b75d02a6
Replace deprecated manifest properties in extension tests r=rpl
https://hg.mozilla.org/integration/autoland/rev/dc3646b4f5a2
Treat (deprecation) warnings as errors r=rpl

The android-hw devices have been using a new image with a newer python2. This started on 9/11 12PM pacific to 9/12 12PM and then has continued from 9/13 5PM pacific onward. The newer python2 may be unoptimized compared to the default py2 on ubuntu. :bobclary questioned if python performance could affect the timing of on-device operations. Let me know if the bisect doesn't reveal anything.

@Andrew I suggest to (re)post that comment at bug 1568050.

Status: REOPENED → RESOLVED
Closed: Last month29 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Flags: needinfo?(rob)
Flags: needinfo?(rob) → qe-verify-
Regressions: 1566843
You need to log in before you can comment on or make changes to this bug.