1570764 - Include SCM revision in GeckoView POM files

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

Trying to determine what version of GeckoView is running in our products is a nightmare (see also Bug 1552583), so let's do everything we can to make it better. In the POM files we produce (e.g., this one), I see:

<scm>
<connection>scm::hg::https://hg.mozilla.org/mozilla-central/</connection>
<url>https://hg.mozilla.org/mozilla-central/</url>
</scm>

Surely we can include an HG revision in there too.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1570764 - Include MOZ_SOURCE_* fields in GeckoView POM files. r?agi

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6862186e032b
Include MOZ_SOURCE_* fields in GeckoView POM files. r=agi

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset 6862186e032b (bug 1570764) for causing toolchains bustages

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=259512976&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=toolchains%2Copt%2Ctoolchain%2Cbuilds%2Cfor%2Clinux%2C64-bits%2Ctoolchain-linux64-android-gradle-dependencies%2Ctl%28gradle-dependencies%29&revision=6862186e032b1b233fba7ccb1220253976e49134

backout: https://hg.mozilla.org/integration/autoland/rev/023a664979ad9d22ddaf02d54d735690d2f5bcd7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a432a8f794b4
Include MOZ_SOURCE_* fields in GeckoView POM files. r=agi

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for toolchain bustages on build.gradle

Backout link: https://hg.mozilla.org/integration/autoland/rev/157b64c54b29d956c757ee6eff17d06c25cb23be
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261161633&repo=autoland&lineNumber=583

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce3c92cf4988
Include MOZ_SOURCE_* fields in GeckoView POM files. r=agi

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ce3c92cf4988

Comment 8

[Nick Alexander :nalexander [he/him]]

I see in https://maven.mozilla.org/maven2/org/mozilla/geckoview/geckoview-nightly/70.0.20190813095543/geckoview-nightly-70.0.20190813095543.pom:

<scm>
<connection>scm::hg::https://hg.mozilla.org/mozilla-central</connection>
<tag>58400ee2747af785469bbecf414d0d739591615c</tag>
</scm>

Comment 9

[Chris Peterson [:cpeterson]]

Should we uplift this POM version fix to GV 69 Beta? I assume we don't need to. Fenix is using GV 69 Beta now and will update to GV 70 Beta about three weeks from now.

Comment 10

[Nick Alexander :nalexander [he/him]]

(In reply to Chris Peterson [:cpeterson] from comment #9)

Should we uplift this POM version fix to GV 69 Beta? I assume we don't need to. Fenix is using GV 69 Beta now and will update to GV 70 Beta about three weeks from now.

Nah, it's just there to help developers go from GV version number to HG commit.