1570766 - Using Third Party Package react-transition-group in New Tab

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, task, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to get approved for vendoring react-transition-group package.

We want to use react-transition-group in New Tab to animate badge notifications.
https://github.com/mozilla/activity-stream/pull/5196/commits/cd8d51daa498068383e8fa9fdbe45ec5346a6a48
https://github.com/reactjs/react-transition-group/blob/master/LICENSE

The package was formerly maintained by React and is now under community support.
https://reactjs.org/docs/animation.html

Comment 1

[Punam Dahiya [:pdahiya]]

NI Dan to help review vendor package. Thanks

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

After review and discussion with :k88hudson, this seems like a reasonable package to add. It

• has most of a page in the core React docs
• is hosted out of the reactjs organization on github
• has reasonable test coverage
• is under the BSD 3-clause license
• gets regular updates from a number of contributors, mostly to keep it in sync with react, improve documentation etc. It appears to be fairly stable.

r=dmose for inclusion in the tree.

Comment 3

[Jessilyn Davis]

Dan, do you have an ETA on this? (Could it be today by chance to unblock some code to export?)

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Yes, I'll do this today.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

After some investigation, I think this actually does pull in code from at least one (and likely 1 or two more) dependencies, so in order to land that, we'd need to accept those dependencies and licenses as well. I'd like to chat with Kate about this, and she's out today. Can this wait until (at least) tomorrow?

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

While investigating this, it looks like we may have an issue with our overall license checking practices for node stuff. I've filed bug 1571901 about this (and will be driving it), but after discussion with :k88hudson, we've decided that it makes sense to not block this bug on sorting that out, largely because we're following existing practice, and, additionally, all of the sub-dependencies for this package have compatible licenses, and all but one of them are already being shipped as part of firefox.

r=dmose

Comment 7

[Jessilyn Davis]

Thanks for investigating this, Dan! We appreciate not blocking on this while the larger issue is being investigated. Good luck on bug 1571901!

Punam, what's the next steps on this bug?

Comment 8

[Punam Dahiya [:pdahiya]]

Scope of this bug was to review react-transition-group package and if its safe to use in code base. With dmose review its ok to resolve fix this bug