Closed
Bug 1570773
Opened 5 years ago
Closed 5 years ago
Move browsingContext getter to nsIDocShellTreeItem
Categories
(Core :: DOM: Navigation, task, P2)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
Details
Attachments
(1 file)
nsIDocShellTreeItem roughly corresponds to BrowsingContext, and uses of the former are gradually being migrated to the latter. In the mean time, having the getter on nsIDocShell requires a lot of unnecessary QueryInterfaces as we're migrating code. Moving the getter to nsIDocShellTreeItem should simplify the process.
|
Assignee | |
Comment 1•5 years ago
|
||
This also renames the existing infallible nsDocShell:GetBrowsingContext()
getter to BrowsingContextRef(), and changes the return type, since several
callers rely on it returning a raw pointer rather than an already_AddRefed.
|
||
Updated•5 years ago
|
Attachment #9082425 -
Attachment description: Bug 1570773: Move browsingContext getter to nsIDocShellTreeItem and make infallible. r=nika → Bug 1570773: Move browsingContext getter to nsIDocShellTreeItem and add notxpcom variant. r=nika
|
||
Comment 2•5 years ago
|
||
Type: defect → task
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Fission Milestone: --- → M4
Priority: -- → P2
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a887ffaf4090 Move browsingContext getter to nsIDocShellTreeItem and add notxpcom variant. r=nika
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•