1570821 - Limit height for variable tooltip to preserve space

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P5)

Description

[:Harald Kirschner :digitarald]

Attachment: Firefox

What were you doing?

1. Pause in an event listener
2. Hover an element or event.target

What happened?

Tooltip taking the full width of the Debugger, which in vertical mode is a lot.

What should have happened?

Limit it to a reasonable size and scroll the rest.

Anything else we should know?

Chrome limit size.

Comment 1

[:Harald Kirschner :digitarald]

Attachment: Chrome

Comment 2

[Florens Verschelde :fvsch]

Limiting the height sounds reasonable. To something like Chrome's or a bit taller maybe.
As mentioned on Slack the left padding seems a bit extra too.

Comment 3

[Krishnal Ciccolella]

I would like to take a stab at this.

Comment 4

[David Walsh :davidwalsh]

Sounds good Krishnal! Let me know if you need help!

Comment 5

[Krishnal Ciccolella]

Attachment: Bug 1570821 - limit height for variable tooltip and decrease left padding r=davidwalsh

Added and if statement to calculateMaxHeight() to prevent it from exceeding 250, and decresed the padding of the .object-node selector.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8dc5c551235
limit height for variable tooltip and decrease left padding r=davidwalsh

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b8dc5c551235