1570852 - trap focus in the delete confirmation dialog

Status: VERIFIED FIXED

(Firefox :: about:logins, task, P2)

Description

[Asa Dotzler [:asa]]

Tabbing through the delete login confirmation dialog goes from the right hand button (cancel) to the left hand button (delete) to the close dialog button. That's shifting focus left and up with rather than right and down with each tab. That seems backwards from the normal flow.

Perhaps we can eliminate the redundant close dialog "x" button and trap the focus in the dialog so that tabbing simply rotates between cancel and delete.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[Matthew N. [:MattN]]

I think the order is less of a problem, in fact it's intentional. I agree about trapping focus in the dialog but I think the better solution is using our existing dialog code from the prompt service which should already do that.

Comment 3

[Lesley Norton [:lnorton]]

Attachment: Bug 1570852: Trap focus in delete confirmation dialog. r=jaws

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41b9eafbaced
Trap focus in delete confirmation dialog. r=jaws

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/41b9eafbaced

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: delete confirmation dialog keyboard navigation.gif

I have verified this issue on the latest Nightly 71.0a1 (2019-09-08) build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64 and I got the following results:

• The focus is not actually stuck in the "Delete this login" dialog. After navigating through the buttons from the dialog using the "Tab" key, the focus jumps to the browser toolbar and a few elements from it can be focused. From what I understand the focus should be stuck in the "Delete this login" dialog and no other buttons should be focused.
  I have attached a screen recording with this behavior.

@Matthew, is this behavior intended?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

This behavior is intended. The webpage cannot prevent focus from moving to the browser chrome. The goal of this bug is just to prevent other buttons within the webpage from gaining focus.

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Thanks, Jared for clarifying this!
Based on comment 6 and comment 7 I will mark this issue as Verified - Fixed.

Comment 9

[Marco Zehe (:MarcoZ)]

Hi Lesley, is this something you'd be comfortable requesting uplift for to 70 beta?

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ccd67751287

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue and is no longer reproducible on the Firefox R-C 70.0 (Build ID: 20191016161957) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The elements from the “about:logins” page are not focused after navigating through the buttons from the “Delete confirmation” dialog using “Tab” key.
• The “Delete” button is automatically focused when the “Delete confirmation” dialog is opened and the “Cancel” button gets focus after pressing the “Tab” key.