1570864 - On developer edition, the "Picture-in-Picture" prompt occasionally fails to display the PiP icon.

Status: RESOLVED WORKSFORME

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Anselm Schüler]

Attachment: firefox_pip-prompt_correct.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

I used Firefox Developer Edition on Windows 10 10.0.18362 Build 18362 on Lenovo Legion Y530 8GB RAM synced to my Sync account using recommended performance settings to browse youtube.com, which displays video. While tab- and window-switching, this happened.

Note: I have not found a reliable method to reproduce this, but it happens often enough that I reckon there'd be no trouble finding an occurrence.

Actual results:

The seemingly Developer-Edtion-exclusive PiP prompt displays as a blue box while inactive and a slightly too long blue rectangle containing the text "Picture-in-Picture" while hovered over.

Expected results:

The seemingly Developer-Edtion-exclusive PiP prompt displays as a blue box containing the PiP icon while inactive and a blue rectangle containing the text "Picture-in-Picture" preceded by the PiP icon while hovered over.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey Anselm,

Thanks for reporting this issue! I want to make sure I understand the difference between the "Actual results" and the "Expected results". I think the important difference is the words "slightly too long".

Can I assume by "slightly too long", you're referring to the actual dimensions of the toggle, rather than the length of time that it's appearing on screen? In what way is the toggle misbehaving - in how it's positioned, in its dimensions, or in how it slides out and back? Or something else entirely?

I'll note that your screenshot is titled "firefox_pip-prompt_correct.png", and the "correct" part makes me unsure of whether or not the screenshot is showing the broken behaviour or the expected behaviour.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Or is the problem that the icon is sometimes missing?

Comment 3

[Anselm Schüler]

The problem is that the icon is sometimes missing. The "slightly too long" was meant to indicate that the box doesn't shrink to accommodate the missing image. I will update the attachment with firefox_pip-prompt_incorrect.png soon - as soon as I'm back on PC. Writing this on mobile. Sorry!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Does the icon eventually appear, or does it stay missing?

Comment 5

[Anselm Schüler]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)

Does the icon eventually appear, or does it stay missing?

It does not reappear while the blue banner is visible.

Comment 6

[Anselm Schüler]

Attachment: firefox_pip-prompt_incorrect.png

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Thanks, Anselm.

Hey Cristian, have you seen this at all in your testing?

Comment 8

[Cristian Craciun]

Hi Mike, I didn't encountered this issue while testing this feature. Should I try specifically the Developer Edition build?

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Whoops - I missed this question.

Yes, Cristian, I think it'd be best to test Developer Edition specifically.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Any updates here, Cristian? Have you been able to reproduce this on Dev Edition?

Comment 11

[Cristian Craciun]

Build ID 20191021164841
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

I've tested on the latest version of Developer Edition but couldn't managed to reproduce the issue. Neither on any other Firefox versions (Beta/Nightly) while testing the feature or doing bug verification.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Hm, alright. Thanks, Cristian.

Do you still see this bug, Anselm Schüler?

Comment 13

[Anselm Schüler]

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #12)

Hm, alright. Thanks, Cristian.

Do you still see this bug, Anselm Schüler?

No. It seems to have been fixed as far as I can see.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Thanks!