1570921 - 1.28 - 1.51% Base Content JS (linux64-shippable, linux64-shippable-qr, macosx1014-64-shippable, windows10-64-shippable, windows10-64-shippable-qr, windows7-32-shippable) regression on push 6c3d3ce32b08ef2f55d75ffe1a19d60b13c11341 (Mon July 29 2019)

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect, P1)

Description

[Marian Raiciof [:marauder]]

We have detected an awsy regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=6c3d3ce32b08ef2f55d75ffe1a19d60b13c11341

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

2% Base Content JS linux64-shippable opt 4,099,749.33 -> 4,161,802.67
2% Base Content JS linux64-shippable-qr opt 4,099,749.33 -> 4,161,749.33
2% Base Content JS macosx1014-64-shippable opt 4,100,672.00 -> 4,162,752.00
2% Base Content JS windows10-64-shippable-qr opt 4,156,586.67 -> 4,218,805.33
1% Base Content JS windows10-64-shippable opt 4,156,773.33 -> 4,218,858.67
1% Base Content JS windows7-32-shippable opt 3,218,496.00 -> 3,259,864.00
1% Base Content JS windows7-32-shippable opt 3,218,522.67 -> 3,259,861.33

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=22249

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/AWSY/Tests

Comment 1

[André Bargull [:anba]]

These memory regressions will be addressed by bug 1570370, which moves the code from self-hosted JS to C++ code.

Comment 2

[Marian Raiciof [:marauder]]

Thank you!

Comment 3

[Liz Henry (:lizzard)]

Vicky, just letting you know about this perf regression which as it stands now, will be shipping in 70.

Comment 4

[Vicky Chin [:vchin]]

Thanks :lizzard. I pinged :sdetar to follow up on bug 1570370.

Comment 5

[Steven DeTar [:sdetar]]

Jeff, can you looking into this. This is a high priority and is needed for this to be address by 71.

Comment 6

[André Bargull [:anba]]

This bug is fixed by bug 1570370 (see improvements for that bug), so I think we can just close this bug. (bug 1570370 is on track for 71.)

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

(In reply to André Bargull [:anba] from comment #6)

This bug is fixed by bug 1570370 (see improvements for that bug), so I think we can just close this bug. (bug 1570370 is on track for 71.)

Closing the bug, thanks.