Closed Bug 1570945 Opened 3 months ago Closed 3 months ago

The "about:logins" page wrongly shows that your are no longer logged into the FxA account after revealing or coping a password

Categories

(Firefox :: about:logins, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox70 --- verified

People

(Reporter: cosmin.muntean, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(2 files)

[Affected Versions]:

  • Nightly 70.0a1

[Affected Platforms]

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]

  • Be logged with a valid FxA account
  • Have at least one saved login.

[Steps to reproduce]:

  1. Open the latest Nightly browser with the profile from prerequisites.
  2. Navigate to "about:logins" page.
  3. Click one of the saved logins.
  4. Click the "Show Password" or "Copy" button next to the password field.
  5. Observe the email and the avatar for the right corner of the "about:logins" page.

[Expected results]:

  • The email and the avatar are correctly displayed.

[Actual results]:

  • The email and the avatar are replaced by the "Sign in to Sync" button.

[Notes]:

  • If the page is refreshed the email and the avatar are correctly redisplayed.
  • Attached a screen recording with the issue.
Assignee: nobody → jaws
Status: NEW → ASSIGNED

I'm going to investigate enabling no-fallthrough in eslint to prevent these from happening again.

Attachment #9083134 - Attachment description: Bug 1570945 - Add missing break; statement in receiveMessage to not fall through to updating sync state. r?MattN → Bug 1570945 - Remove unnecessary default case in AboutLoginsParent.jsm. r?MattN

This bug was indirectly fixed by bug 1549808. I'm going to land the patch here just to remove the unnecessary 'default' case in AboutLoginsParent.jsm.

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/157fd6afba69
Remove unnecessary default case in AboutLoginsParent.jsm. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Blocks: 1572049

I have verified this issue on the latest Nightly 70.0a1 build (2019-08-08) (64 bit) on Windows 10 x64, Windows 7 x64m Mac 10.14 and Ubuntu 18.04.

  • The email and the avatar are correctly displayed after revealing or coping a password.
Status: RESOLVED → VERIFIED
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
You need to log in before you can comment on or make changes to this bug.