Closed Bug 1571063 Opened 5 years ago Closed 5 years ago

Simplify BrowsingContext field sync logic

Categories

(Core :: DOM: Navigation, enhancement, P2)

Product:
Core
Component:
DOM: Navigation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(1 file)

Bug 1571063 - Simplify BrowsingContext field sync logic,
47 bytes, text/x-phabricator-request
Details | Review

The current logic is a bit complex, sometimes asserts in awkward places, and can be tricky to use. This bug is tracking some simplification, and streamlining work which should also help deal with the assertion issues.

Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14e11bbc0dd3
Simplify BrowsingContext field sync logic, r=farre

https://hg.mozilla.org/mozilla-central/rev/14e11bbc0dd3

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Backed out changeset 14e11bbc0dd3 (Bug 1571063) for geckoview-web-platform-tests failures at /html/cross-origin/anonymous.tentative.html

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-web-platform-tests-e10s-10%2Cw%28wpt10%29%2Cbd4b16f1c17e07a265097f9f31e81026f4f2c24f&revision=14e11bbc0dd3d1d315a0e261fbcdbb8ae6f8482e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=260649387&repo=autoland&lineNumber=3360

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=260656253&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=8017e6d5cbb68c769f6a19ec23228dfd00732e2f

[task 2019-08-08T20:06:51.477Z] 20:06:51     INFO - TEST-START | /html/cross-origin/anonymous.tentative.html
[task 2019-08-08T20:06:51.491Z] 20:06:51     INFO - Setting pref browser.tabs.remote.useCrossOriginPolicy (true)
[task 2019-08-08T20:06:57.762Z] 20:06:57     INFO - 
[task 2019-08-08T20:06:57.762Z] 20:06:57     INFO - TEST-UNEXPECTED-FAIL | /html/cross-origin/anonymous.tentative.html | Top-level with anonymous policy: navigating a frame to a null policy should fail. - assert_equals: expected null but got Document node with 1 child
[task 2019-08-08T20:06:57.762Z] 20:06:57     INFO - @http://web-platform.test:8000/html/cross-origin/anonymous.tentative.html:13:18
[task 2019-08-08T20:06:57.762Z] 20:06:57     INFO - Test.prototype.step_timeout/<@http://web-platform.test:8000/resources/testharness.js:1669:22
[task 2019-08-08T20:06:57.762Z] 20:06:57     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1611:25
[task 2019-08-08T20:06:57.762Z] 20:06:57     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1635:35
[task 2019-08-08T20:06:57.763Z] 20:06:57     INFO - 
[task 2019-08-08T20:06:57.763Z] 20:06:57     INFO - TEST-UNEXPECTED-FAIL | /html/cross-origin/anonymous.tentative.html | Top-level with anonymous policy: navigating a frame from an anonymous policy to a null policy should fail. - assert_equals: Navigation to null policy should fail expected null but got Document node with 1 child
[task 2019-08-08T20:06:57.763Z] 20:06:57     INFO - bc.onmessage</<@http://web-platform.test:8000/html/cross-origin/anonymous.tentative.html:31:20
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - Test.prototype.step_timeout/<@http://web-platform.test:8000/resources/testharness.js:1669:22
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1611:25
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1635:35
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - 
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - TEST-UNEXPECTED-FAIL | /html/cross-origin/anonymous.tentative.html | Top-level with anonymous policy: navigating a frame from a use-credentials policy to a null policy should fail. - assert_equals: Navigation to null policy should fail expected null but got Document node with 1 child
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - bc.onmessage</<@http://web-platform.test:8000/html/cross-origin/anonymous.tentative.html:52:20
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - Test.prototype.step_timeout/<@http://web-platform.test:8000/resources/testharness.js:1669:22
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1611:25
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1635:35
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - 
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - TEST-PASS | /html/cross-origin/anonymous.tentative.html | Top-level with anonymous policy: creating a noopener popup with null policy should work. 
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - TEST-PASS | /html/cross-origin/anonymous.tentative.html | Top-level with anonymous policy: creating a popup with null policy should fail. 
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - TEST-PASS | /html/cross-origin/anonymous.tentative.html | Top-level noopener with anonymous policy: navigating to a different policy should work 
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - TEST-UNEXPECTED-FAIL | /html/cross-origin/anonymous.tentative.html | Fetch policy: anonymous policy no-cors fetches should be changed to cors - assert_equals: type should have been changed to cors expected "cors" but got "opaque"
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - @http://web-platform.test:8000/html/cross-origin/anonymous.tentative.html:127:18
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - @http://web-platform.test:8000/html/cross-origin/anonymous.tentative.html:151:20
[task 2019-08-08T20:06:57.764Z] 20:06:57     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1611:25
[task 2019-08-08T20:06:57.765Z] 20:06:57     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:576:22
[task 2019-08-08T20:06:57.765Z] 20:06:57     INFO - @http://web-platform.test:8000/html/cross-origin/anonymous.tentative.html:132:11
Flags: needinfo?(nika)
status-firefox70: fixed → ---
Target Milestone: mozilla70 → ---
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3194b8199d82
Removing comment lines, part of 8017e6d5cbb6. Relanded with the correct bug number on a CLOSED TREE DONTBUILD

https://hg.mozilla.org/mozilla-central/rev/3194b8199d82

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Merge of backout to central: https://hg.mozilla.org/mozilla-central/rev/8017e6d5cbb6

Status: RESOLVED → REOPENED
status-firefox70: fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla70 → ---
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/777ff87ba07a
Simplify BrowsingContext field sync logic, r=farre
Flags: needinfo?(nika)

https://hg.mozilla.org/mozilla-central/rev/777ff87ba07a

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: