1571118 - Keep NS_FRAME_FIRST_REFLOW bit in nsBlockFrame::Reflow() a bit longer

Status: RESOLVED FIXED

(Core :: Layout, task, P5)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I notice that NS_FRAME_FIRST_REFLOW is cleared in the middle of nsBlockFrame::Reflow while developing a patch in https://phabricator.services.mozilla.com/D40245.

Although in the end the patch didn't require the bit to live for the full duration of nsBlockFrame's first reflow, I feel it might be better to keep the bit until nsFrame::DidReflow removes it in case anyone wants to add code to inspect it in the future.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1571118 - Keep NS_FRAME_FIRST_REFLOW bit in nsBlockFrame::Reflow() until nsFrame::DidReflow(). r=dholbert

This patch lets nsBlockFrame keep its NS_FRAME_FIRST_REFLOW bit a bit
longer, for the full duration of its first reflow, so that in the future
we may add more code to inspect it if needed before nsFrame::DidReflow()
clears it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c48170ebbe2
Keep NS_FRAME_FIRST_REFLOW bit in nsBlockFrame::Reflow() until nsFrame::DidReflow(). r=dholbert

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3c48170ebbe2