1571151 - Simplify SVGPathData parser.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Just some minor things I noticed while looking at bug 1571119.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1571151 - Deindent a bit SVG path parsing code. r=boris

None cannot be returned, since we just called peek() and it returned something.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1571151 - Expand and simplify a macro that's not very useful. r=boris

Skip whitespace upfront rather than on each individual branch. The only
difference in behavior is that we would've consumed some extra whitespace in the
error case, but I don't think that matters at all.

We were consuming some extra whitespace as well after the close path command for
example, which wasn't parsing anything.

Depends on D40538

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3546b012b87
Deindent a bit SVG path parsing code. r=boris
https://hg.mozilla.org/integration/autoland/rev/ca4e23649101
Expand and simplify a macro that's not very useful. r=boris

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f3546b012b87
https://hg.mozilla.org/mozilla-central/rev/ca4e23649101