Closed Bug 1571237 Opened 6 months ago Closed 5 months ago

Color picker broken for RTL locales

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox68 unaffected, firefox69 unaffected, firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: itiel_yn8, Assigned: mislam)

References

(Regression)

Details

(Keywords: regression, rtl)

Attachments

(4 files)

Attached image Current state RTL

See attached for how it looks right now for RTL vs. LTR.

  1. The selected spectrum is wrong
  2. Same for the Opacity slider
  3. The More Info (i) icon should be located at the left-most position
  4. The "<contrastnumber>AAA" looks wrong. Should look like the attached screenshot.
Attached image Current state LTR
Flags: needinfo?(mislam)

The CSS code for this part seems to live here: https://searchfox.org/mozilla-central/rev/0ffa9e372df56c95547fed9c3433ddec4fbf6f11/devtools/client/shared/widgets/spectrum.css#184-223
It already uses a lot of logical CSS properties, so it shouldn't be too much work to iron out the kinks.

Priority: -- → P3
Assignee: nobody → mislam
Status: NEW → ASSIGNED
Flags: needinfo?(mislam)
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.