Closed
Bug 1571237
Opened 5 years ago
Closed 5 years ago
Color picker broken for RTL locales
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox68 unaffected, firefox69 unaffected, firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: mislam)
References
(Regression)
Details
(Keywords: regression, rtl)
Attachments
(4 files)
Current state RTL
See attached for how it looks right now for RTL vs. LTR.
- The selected spectrum is wrong
- Same for the Opacity slider
- The More Info (i) icon should be located at the left-most position
- The "<contrastnumber>AAA" looks wrong. Should look like the attached screenshot.
|
||
Comment 3•5 years ago
|
||
The CSS code for this part seems to live here: https://searchfox.org/mozilla-central/rev/0ffa9e372df56c95547fed9c3433ddec4fbf6f11/devtools/client/shared/widgets/spectrum.css#184-223
It already uses a lot of logical CSS properties, so it shouldn't be too much work to iron out the kinks.
|
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mislam
Status: NEW → ASSIGNED
Flags: needinfo?(mislam)
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27a870473b4d
Fix color picker for RTL locales, r=gl
Keywords: checkin-needed
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
|
||
Updated•5 years ago
|
status-firefox68:
--- → unaffected
status-firefox69:
--- → unaffected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
|
||
Updated•5 years ago
|
QA Whiteboard: [good first verify]
|
||
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•