1571243 - [RTL] Mirror the popup-subitem.svg icon on the geolocation access indicator

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Itiel]

Attachment: Screenshot - current state RTL

This icon should be mirrored for RTL.

Adding this rule:

.popup-subitem:-moz-locale-dir(rtl) {
  transform: scaleX(-1);
}

here:
https://searchfox.org/mozilla-central/source/browser/themes/shared/notification-icons.inc.css#230
fixes the issue for me.

Comment 1

[Itiel]

Attachment: Bug 1571243 - Mirror the popup-subitem.svg icon on the geolocation access indicator

Comment 2

[Itiel]

I'm hoping I did everything correctly here.. first time submitting a patch.

How can I know who can/should review my patch? I arbitrarily selected you johannh simply because you're the triage owner..

Comment 3

[Johann Hofmann [:johannh]]

This arrow was already present for popups, so I wouldn't say bug 630614 is at fault :)

(In reply to Itiel from comment #2)

I'm hoping I did everything correctly here.. first time submitting a patch.

How can I know who can/should review my patch? I arbitrarily selected you johannh simply because you're the triage owner..

All good, thank you for the patch, it's highly appreciated!!

There's one thing that I need you to do before this can land: Lando, or landing tool, tells me Diff does not have proper author information in Phabricator. and points to this FAQ article (3rd item in the FAQ).

Did you create this patch using arcanist/moz-phab? If not, you will need to set it up. Otherwise you might need to edit your .hgrc file to include you name and then run hg commit --amend and moz-phab again.

Let me know if you have any questions.

Thanks!

Comment 4

[Itiel]

Thanks for the info.

I had arcanist set up but apparently didn't have the .hgrc file. I've done as you've asked but I'm not sure I did it right.
Can you please verify?

Thanks!

Comment 5

[Tim Nguyen :ntim]

(In reply to Itiel from comment #4)

Thanks for the info.

I had arcanist set up but apparently didn't have the .hgrc file. I've done as you've asked but I'm not sure I did it right.
Can you please verify?

Thanks!

Looks like Lando is still showing the warning.

Can you try running ./mach vcs-setup, completing all the information, hg commit --amend and moz-phab again?

Thanks :)

Comment 6

[Itiel]

Attachment: Bug 1571243 - Mirror the popup-subitem.svg icon for RTL

Comment 7

[Itiel]

(In reply to Tim Nguyen :ntim from comment #5)

Looks like Lando is still showing the warning.

Can you try running ./mach vcs-setup, completing all the information, hg commit --amend and moz-phab again?

Thanks :)

I ended up removing the entire mozilla-central and redownloaded the entire thing..
I think I did it right this time.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a5e94ecef1a
Mirror the popup-subitem.svg icon for RTL r=ntim

Comment 9

[Tim Nguyen :ntim]

Seems like it works correctly now, thanks!

Comment 10

[Itiel]

(In reply to Tim Nguyen :ntim from comment #9)

Seems like it works correctly now, thanks!

Thank you!
Where can I ask more about stuff to do with hg/arc etc? Online docs I find seem to require some prior knowledge.

Comment 11

[Tim Nguyen :ntim]

(In reply to Itiel from comment #10)

(In reply to Tim Nguyen :ntim from comment #9)

Seems like it works correctly now, thanks!

Thank you!
Where can I ask more about stuff to do with hg/arc etc? Online docs I find seem to require some prior knowledge.

The #developers channel on IRC is a good place to ask if you have questions: https://developer.mozilla.org/en-US/docs/Mozilla/QA/Getting_Started_with_IRC

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8a5e94ecef1a