1571249 - remove BCTableCell as a distinct LayoutFrameType

Status: RESOLVED FIXED

(Core :: Layout: Tables, task, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd like to remove BCTableCell as a distinct LayoutFrameType. I did this as part of work on bug 1547759, but since (a) I'd like to keep the stuff on that bug not too huge and (b) this change probably fixes some existing bugs on its own, I'd like to move it to a separate bug.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Try runs for this are linked in bug 1547759.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Bug 1571249 - Remove BCTableCell as a distinct frame type.

There are two existing callers of IsTableCellFrame that both appear to want to
include BCTableCell frames, but don't. A patch in bug 1547759 will add a
third that wants the same.

The existing users of frame types all have to work around it being a distinct
type, and none appear to want the distinction. This removes that complexity.

If any callers want to make the distinction, they could implement QueryFrame
for BCTableCellFrame and use it. (It's not implemented now, though!)

In a little more detail, prior to this patch (in my debug build, at least):

• nsQueryFrame::ClassID::nsMathMLmtdFrame_id was 46
• nsQueryFrame::ClassID::nsTableCellFrame_id was 47
• nsQueryFrame::ClassID::nsBCTableCellFrame_id was 65
  and entries 46 and 47 in sLayoutFrameTypes were
  mozilla::LayoutFrameType::TableCell while entry 65 was
  mozilla::LayoutFrameType::BCTableCell.

With this patch:

• nsQueryFrame::ClassID::nsBCTableCellFrame_id is 40
• nsQueryFrame::ClassID::nsMathMLmtdFrame_id is 41
• nsQueryFrame::ClassID::nsTableCellFrame_id is 42
  and entries 40 through 42 in sLayoutFrameTypes are
  mozilla::LayoutFrameType::TableCell.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Bug 1571249 - Remove the IsTableCell() function.

It was made pointless by the previous patch.

This replaces callers that had a frame type for another reason with the
frame type check that IsTableCell did, and callers that needed to call
Type() with an IsTableCellFrame call.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44bfb4911daf
Remove BCTableCell as a distinct frame type. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/6fd3876db7c6
Remove the IsTableCell() function. r=TYLin

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/44bfb4911daf
https://hg.mozilla.org/mozilla-central/rev/6fd3876db7c6