Closed Bug 1571250 Opened 5 years ago Closed 5 years ago

convert flags passed to ReflowChild/FinishReflowChild/etc. to an enum class

Categories

(Core :: Layout, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(1 file)

As part of bug 1547759, where I wanted to add a new flag but didn't like the idea of doing it when it required picking the correct 0 to change to a non-0 value, I'd like to convert the set of flags passed to ReflowChild, FinishReflowChild, and SyncFrameViewAfterReflow and from GetXULLayoutFlags and GetLayoutFlags into an enum class.

Try runs for this are linked in bug 1547759.

It seems better to convert this before adding a new flag (in bug
1547759) and risking replacing the wrong 0 with a flag.

Pushed by dbaron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/905117fbca93
Convert flags passed to ReflowChild, FinishReflowChild, SyncFrameViewAfterReflow and from GetXULLayoutFlags / GetLayoutFlags into an enum class. r=TYLin
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: