1571265 - The "Firefox Help" text is missing from the Help menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[tgn-ff]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Open the Help menu either from the Hamburger menu or the toolbar.

Actual results:

The "Firefox Help" entry has no text anymore.

Expected results:

It should have text or be completely removed.

---

Bisection points to Bug 1501886.

8:12.44 INFO: Last good revision: cc5b3d1d6869db8c61a46f87b635386279503329
8:12.44 INFO: First bad revision: 1f622156e9eab1d2c58d5d77bb5908fcc83db253
8:12.44 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cc5b3d1d6869db8c61a46f87b635386279503329&tochange=1f622156e9eab1d2c58d5d77bb5908fcc83db253

Comment 1

[Francesco Lodolo [:flod]]

As far as I can tell, everything looks normal on macOS. Is there an empty line instead of the text? Can you add a screenshot?

Comment 2

[Francesco Lodolo [:flod]]

OK, the item is completely gone.

Looks like the label was outside the IFDEF, with only the accesskey inside, and now it moved inside
https://hg.mozilla.org/mozilla-central/rev/1f622156e9eab1d2c58d5d77bb5908fcc83db253#l2.650

Comment 3

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: hamburger-menu.png

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: menubar.png

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1571265 - Move back the Help L10n ID to cover all platforms. r?flod

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thank you for reporting the bug!

One more thing to pay attention to when automating migrations.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79d990c8596c
Move back the Help L10n ID to cover all platforms. r=flod

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/79d990c8596c