1571271 - protections.etpON.header notification is cut off in French

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Théo Chevalier]

Attachment: Screenshot, French

With a French build, and when turning on ETP for a website, the text in the notification panel is cut off.

More specifically, in the screenshot the final E in ACTIVÉE is cut off.

I couldn’t reproduce with the notification when turning it off.

Comment 1

[Francesco Lodolo [:flod]]

Confirming on Italian build, both enabling and disabling ETP.

Comment 2

[Tim Huang[:timhuang]]

I think the root cause here is that the width of the panel header is not correctly bounded. So, it will render weirdly if the description in the header is wider than the header itself.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1571271 - Fix the width setting of the headers of protection panel. r?johannh!

The header of the protection panel doesn't have a correct setting of
width, so it would render weirdly if the description in that is longer
than the header itself. The patch adds rules for fixing this problem.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df3df7016bb0
Fix the width setting of the headers of protection panel. r=johannh

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/df3df7016bb0

Comment 6

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 x64, Ubuntu 18.04 x64 and macOS 10.14 using Firefox 70 Beta 9 (20190923154733) - "fr", "it" and "pt-PT" builds.