1571318 - Event bubble inline source code view scrolling is broken

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Trevor Rowbotham [:rowbot]]

Attachment: inspector.PNG

Sorry, not sure what feature name this goes by anymore (Visual Events/Event Bubbles/Examine Event Listener)? The inline source code viewer seems to overflow its container, causing text to appear cutoff.

STR:

1. Go to a page with event listeners registered. (Firefox's Activity Stream should do fine)
2. Click on the event bubble next to the element in the Inspector.
3. Find an event that requires you to scroll to see the entire source code inline.
4. The bottom of the source code view is cutoff.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

I can reproduce this on nightly, but not on devedition by opening any event bubble to view the inline source. Looking at the differences between the css. It seems we are no longer setting the iframe width and height, which contains the CM editor.

For comparison, this is the CSS I saw that was missing:
width: 100%;
height: 100%;
border-style: none;

@miker, any chance you could look at this?

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

This does not appear to be a regression. It seems we are running into a CSP when calling setAttribute for an iframe in EventTooltipHelper.js#265.

This is the error reported:
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”). EventTooltipHelper.js:265:13

One idea for the fix would be to add a class for the iframe and move the styles into the tooltips.css stylesheet.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

.

Comment 4

[Julian Descottes [:jdescottes]]

I will take it since it's a regression from the CSP change

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1571318 - Stop using inline styles in event tooltip

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c4d643cd88a
Stop using inline styles in event tooltip r=gl

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9c4d643cd88a