1571418 - Don't allow editing login origin from about:logins

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: edit addresses.gif

[Affected Versions]:

• Nightly 70.0a1 (Build ID: 20190804214813)

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have at least one saved login.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Navigate to "about:logins" page and click one of the saved logins.
3. Click the "Edit" button.
4. Enter a new website in the "Website Address" field.
5. Click the "Save changes" button.
6. Click the "Launch" button and observe which website is opened in a new tab.
7. Return to "about:logins" tab and refresh the page.
8. Observe the edited login.

[Expected results]:
Step 6. The newly added website is opened.
Step 8. The new website is displayed.

[Actual results]:
Step 6. The previous website is opened instead of the new one.
Step 8. The previous website is displayed instead of the new one.

[Notes]:

• Please note that the deleted website remains displayed on the login card from the sidebar and also as the title of the saved login.
• Attached a screen recording with the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1571418 - Save changes to the origin when editing logins. r?MattN

Comment 2

[Matthew N. [:MattN]]

I thought the website wasn't supposed to be editable? It wasn't in the old UI or in the initial scope.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

This was requested during our UX feedback round in bug 1558242. It is visible in the UX spec at https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372931544.

Comment 4

[Matthew N. [:MattN]]

This is a footgun as many users don't understand origins and so they will edit things and then wonder why they don't work. They will also be confused if they change the origin but don't change the formActionOrigin because they can't see it anywhere in the UI… What is our plan to handle that?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

It would be easier for us to just disable editing of the origin. The extension doesn't allow it. I have to unassign the bug, but hopefully we can come to an agreement here. I'm in favor of disabling the editing of the origin.

Comment 6

[Matthew N. [:MattN]]

https://searchfox.org/mozilla-central/diff/8cbce8bd6e6388bf1cd16970891b6498c047efed/browser/components/aboutlogins/content/components/login-item.js#369 was the change that added it. Looks like you need to use:

this._originInput.readOnly = !this.dataset.isNewLogin

Comment 7

[Tim Nguyen :ntim]

Attachment: Bug 1571418 - Don't allow editing login origin from about:logins. r=MattN

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/528db640f50f
Don't allow editing login origin from about:logins. r=MattN

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/528db640f50f

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Nightly 70.0a1 build (2019-08-11) (64 bit) on Windows 10 x64, Mac 10.14 and Arch Linux.

• The "Website Address" field can no longer be edited by the users.