1571421 - Remove "await" workarounds in tests after switching hosts (toolbox in a content frame)

Status: NEW

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

The change introduced by Bug 1539979 is introducing some intermittent behaviors.

Some of them are related to switchHost, which seems to be more async than it used to. Maybe there is a different event on which we need to wait for when DevTools are running in a content frame.

The current plan for such failures is to wait in the tests after calling switchHost. We should find a better solution and remove the calls to wait()

Some other intermittents don't seem directly related to switchHost. For those my current plan is to force DevTools back to a chrome frame, just for the duration of the test via

await pushPref("devtools.toolbox.content-frame", false);

The identified intermittents for now are:

• devtools/client/webconsole/test/mochitest/browser_jsterm_screenshot_command_clipboard.js
• devtools/client/shared/test/browser_html_tooltip_consecutive-show.js

Until those intermittents are fixed, we need to keep some support for DevTools running in a chrome frame. But if it remains test-only, then the platform workaround could still be removed.

Comment 1

[Alexandre Poirot [:ochameau]]

There is some focus workaround in https://phabricator.services.mozilla.com/D40994 which may be removed?

Comment 2

[Alexandre Poirot [:ochameau]]

A few wait() calls have been added in https://phabricator.services.mozilla.com/D40995

Comment 3

[Julian Descottes [:jdescottes]]

Thanks!

Tests that have await statements that should be cleaned up:

• devtools/client/inspector/markup/test/browser_markup_events-windowed-host.js
• devtools/client/inspector/rules/test/browser_rules_eyedropper.js
• devtools/client/inspector/test/browser_inspector_pane-toggle-04.js
• devtools/client/netmonitor/test/browser_net_prefs-reload.js
• devtools/client/shared/test/browser_html_tooltip_zoom.js

Tests that force devtools.toolbox.content-frame to false:

• devtools/client/webconsole/test/mochitest/browser_jsterm_screenshot_command_clipboard.js
• devtools/client/shared/test/browser_html_tooltip_consecutive-show.js
• devtools/client/shared/test/browser_treeWidget_keyboard_interaction.js
• devtools/client/shared/test/browser_treeWidget_mouse_interaction.js

Comment 4

[Julian Descottes [:jdescottes]]

Let's split the bug in two. This one will be only about fixing the tests where we added 1s wait after switching hosts.

Comment 5

[Julian Descottes [:jdescottes]]

Marco: sorry I mixed the priority of the two bugs :) This one is not critical to fix, the other one is (Bug 1578979).

Comment 6

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6)

Comment 7

[Chris Peterson [:cpeterson]]

dt-fission-reserve bugs do not need to block Fission Nightly (M6).

Comment 8

[Chris Peterson [:cpeterson]]

Tracking dt-fission-reserve bugs for Fission MVP until we know whether they really need to block Fission or not.

Comment 9

[Chris Peterson [:cpeterson]]

Moving old "dt-fission-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.