1571444 - No message is displayed in the Login list if the search returns 0 results

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: search results 0.gif

[Affected Versions]:

• Nightly 70.0a1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Prerequisites]

• Have a Firefox profile with multiple saved logins.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Perform a search that returns 0 results.
4. Observe the login list.

[Expected results]:

• A "No matching logins" message is displayed.

[Actual results]:

• No message is displayed, the list is blank.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[Matthew N. [:MattN]]

Ryan, should we show the "No logins found" text but without the "When you save…" paragraph?

Comment 2

[rgaddis]

Screenshot attached... I think it should look quite a bit like that, but have a slightly updated subtitle for no results found. Screenshot attached.

Zeplin: https://zpl.io/aRGlyj0

Comment 3

[rgaddis]

Attachment: Lockwise Desktop Home (No Search Results).png

Comment 4

[rgaddis]

It's also worth mentioning that we should consider closing out of the previously-selected login detail if it no longer matches the search query, no? (based on the screencap above, it seems weird to have facebook still active)

Comment 5

[David Durst [:ddurst]]

Moving to P1 because strings (and because the resulting UX without it is not great) to make this block launch, with Product and UX blessing.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1571444 - Show a message in the sidebar when the search returns 0 results. r?MattN

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

The attached patch doesn't address comment #4 yet. Should we interrupt the filter to ask the user if they want to discard their changes? Should we also select the first login in the list as the user types?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)

The attached patch doesn't address comment #4 yet. Should we interrupt the filter to ask the user if they want to discard their changes? Should we also select the first login in the list as the user types?

Actually this is all tracked in bug 1575561 so I think we should leave it out of this patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7004b8779a36
Show a message in the sidebar when the search returns 0 results. r=MattN,fluent-reviewers,flod

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7004b8779a36

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 70.0a1 (2019-08-29) (64-bit) on Windows 7 c64, MacOS 10.14 and Ubuntu 18.04.

• The "No logins found | There are no results matching your search. " message is displayed on the Login List if the search returns 0 results.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.