1571449 - Invalid "Response has been truncated" message displayed when devtools.netmonitor.responseBodyLimit=0

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[7cf148fd]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

Using Firefox Quantum 68.0.1 (64 bit) on MacOS
Set devtools.netmonitor.responseBodyLimit to 0 to prevent responses from being truncated in the dev tools
Restart the browser and load any page

Actual results:

In the Developers Tools / Request Details panel / Response tab, for each and every element that is not a picture, the response is indeed not truncated but a "Response has been truncated" message (with a Red background) is displayed on top of the Response payload.

Expected results:

The "Response has been truncated" message on red background should not appear when devtools.netmonitor.responseBodyLimit is equal to 0.

Comment 1

[7cf148fd]

Following my comment on Bug 1223726

Comment 2

[7cf148fd]

Attachment: screen capture showing the message erroneously displayed

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!
Honza

Comment 5

[7cf148fd]

The faulty code is in devtools/client/netmonitor/src/components/ResponsePanel.js

106 if (limit <= request.responseContent.content.size) {

should be

106 if ( limit > 0 && limit <= request.responseContent.content.size ) {

Sorry I don't have a mercurial instance at hand to commit this myself.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the pointer!

Honza

Comment 7

[[:Towkir] Ahmed]

Attachment: Bug 1571449 - Invalid "Response has been truncated" message display condition fixed. r=honza

Comment 8

[[:Towkir] Ahmed]

https://phabricator.services.mozilla.com/D40884

Is this how we push codes for review now honza ?

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to [:Towkir] Ahmed from comment #8)

Is this how we push codes for review now honza ?

Yes, thanks for the patch!

Honza

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24417b4ad42e
Invalid "Response has been truncated" message display condition fixed. r=Honza

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/24417b4ad42e