1571470 - Support webrtc-svc (scalabilityMode)

Status: ASSIGNED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Byron Campen [:bwc]]

We should disable the webrtc-svc wpt until we support this stuff too.

Comment 1

[Michael Froman [:mjf]]

Marking this a P2 for now. @Byron, please change if you disagree.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

The main API to implement here is the scalabilityMode encoding parameter.

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add scalabiltyMode to RTCRtpEncodingParameters;r?dbaker

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add pref to enable svc mode for WebRTC;r?dbaker

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - webrtc-svc vp9 wpt tests expect PASS;r?dbaker

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: WIP: Bug 1571470 - add "webrtc" to MediaEncodingType;r?pehrsons

MediaEncodingType in Firefox uses the non-standard "transmission" enum variant instead of "webrtc".
https://developer.mozilla.org/en-US/docs/Web/API/MediaCapabilities/encodingInfo#webrtc

But we don't ever use values of this type so it should be safe to add a spec conforming variant.
https://searchfox.org/mozilla-central/search?q=symbol:E_%3CT_mozilla%3A%3Adom%3A%3AMediaEncodingType%3E_Transmission&redirect=false

This bug is not the correct place to resolve removing the old "transmission" variant.

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - expand setParameters mochitests with scalabilityMode;r?bwc

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add SVC mode fallback;r?dbaker

Comment 9

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: WIP: Bug 1571470 - add dependency descriptor rtp header extension;r?pehrsons

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - update RTCRtpParameters-scalability-av1 expectations to PASS;r?dbaker

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - update RTCRtpParameters-scalability-vp8 expectations to PASS;r?dbaker

Comment 12

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - update RTCRtpParameters-scalability-vp9 expectations to PASS;r?dbaker

Comment 13

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - update RTCRtpParameters-scalability-h264 expectations;r?dbaker

Comment 14

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - update RTCRtpParameters-scalability expectations to PASS;r?dbaker

Comment 15

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add scalabilityMode to stats webidl;r?dbaker

Comment 16

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add scalabilityMode stat handling to WebrtcGlobal;r?dbaker

Comment 17

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - fill in scalabilityMode stat in RTPSender, and WPT;r=dbaker,pehrsons

Comment 18

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - set scalabilityMode stat WPT expectation;r?dbaker

Comment 19

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add scalabilityMode stat handling to GetStats mochitest;r?dbaker

Comment 20

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add wpt helper to check that SVC is used when requested;r=jib,pehrsons

Comment 21

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add common ScalabilityInfo;r?dbaker,pehrsons

Comment 22

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add svc status to aboutWebrtc;r?dbaker

Comment 23

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add dd header extension;r=bwc,pehrsons

Comment 24

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - implement SVC addTransceiver;r=dbaker

Comment 25

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - implement SVC setParameters;r=dbaker

Comment 26

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - implement SVC getParameters;r=dbaker

Comment 27

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - apply SVC configuration;r=dbaker,pehrsons

Comment 28

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add SVC related failure metrics;r=bwc

Comment 29

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add common ScalabilityInfo;r?dbaker

Comment 30

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add SVC setParameters failures;r=dbaker,bwc

Comment 31

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add video conduit test for setting scalabilty mode;r=bwc

Comment 32

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - wpt to verify VP9 produces correct SVC layers;r=jib,pehrsons

Comment 33

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - wpt to verify AV1 produces correct SVC layers;r=jib,pehrsons

Comment 34

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - wpt to verify VP8 produces correct SVC layers;r=jib,pehrsons

Comment 35

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - wpt to verify H264 produces correct SVC layers;r=jib,pehrsons

Comment 36

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - mochitest to verify glean probes;r=dbaker,bwc

Comment 37

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add WPT to check that setting scalabilityMode fails for audio;r?jib

Comment 38

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - store ScalabilityInfo in PeerConnectionImpl;r=pehrsons

Comment 39

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - update A/V extmap verification mochitests with dd;r=dbaker

Comment 40

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - wpt to verify H265 produces correct SVC layers;r=jib,pehrsons

Note these tests are expected to fail until we support h265. They fail to
find the h265 codec early on, so the tests exit before going into the loop
waiting for results. This makes the failures nearly instant.

Comment 41

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - update video extmap verification gtest with dd;r=bwc

Comment 42

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add a list of all webrtc codecs;r=pehrsons

This is used by ScalabilityInfo but could probably be used elsewhere.
It has been moved into its own header as per-the rules layed out in
the style guide:

https://firefox-source-docs.mozilla.org/code-quality/coding-style/coding_style_cpp.html#header-files

Comment 43

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add GetOrCreateExtmap SDP accessor;r=pehrsons

The process of ensuring we have an extmap list before access is fraught.
This adds a version that creates a list if and only if one doesn't exist.

Comment 44

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add DD control preferences;r=pehrsons

Comment 45

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add DD prefs to DefaultCodecPreferences;r=pehrsons

Comment 46

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add a list of all webrtc codecs;r=pehrsons

This is used by ScalabilityInfo but could probably be used elsewhere.
It has been moved into its own header as per-the rules layed out in
the style guide:

https://firefox-source-docs.mozilla.org/code-quality/coding-style/coding_style_cpp.html#header-files

Comment 47

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add test for SVC pref off behavior;r=pehrsons

Comment 48

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: WIP: Bug 1571470 - WIP - changing dd extmap negotitation

Comment 49

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - fall back if media capabilities is not supported;r=jib

Comment 50

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - add WPTs for SVC layer decoding;r=pehrsons

Comment 51

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1571470 - adding missing basic svc setParameters and addTransceiver tests;r=pehrsons

Comment 52

[[:anutrix]]

Any reason so many patches are accepted but not merged? Is the plan to merge them all together?

Comment 53

[Andreas Pehrson [:pehrsons]]

(In reply to [:anutrix] from comment #52)

Any reason so many patches are accepted but not merged? Is the plan to merge them all together?

Yes -- consider it a huge patch broken down into small pieces.