Fix shutdown leaks with Fission enabled
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
A lot of mochitests fail under Fission because they leak TabGroups in the tab processes they create.
Assignee | ||
Comment 1•5 years ago
|
||
Currently, TabGroups know to break their reference cycles only when the last
window leaves them. For TabGroups which have never had a window join (which
happens under Fission), this means they also never see a window leave, and
therefore never break their reference cycles, and leak.
This patch adds a check to break reference cycles if no windows have joined by
the time a BrowserChild they belong to is destroyed.
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3011b29e256265bb4f5a9f53feb070b834f1922e Bug 1571502: Don't leak TabGroups which have never had windows joined to them. r=nika
Comment 3•5 years ago
|
||
bugherder |
Assignee | ||
Comment 4•5 years ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8c98f638d6cd Follow-up: Remove straggler shutdown leak annotations after rebase.
Comment 6•5 years ago
|
||
bugherder |
Comment 7•5 years ago
|
||
After the changes in https://hg.mozilla.org/mozilla-central/rev/3011b29e2562 landed, devtools fission jobs started almost permafailing because of leaks:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-devtools-chrome-fis-e10s-&tochange=e332c573c0b625f38520331709425809f0dd4d2f&fromchange=8ac0a35be0d35f9f5aba38ed841cb3d03a2ae3c8&selectedJob=262096868
Nika, could you please take a look at this?
Updated•5 years ago
|
Assignee | ||
Comment 9•5 years ago
|
||
I think the devtools leaks have been fixed.
Description
•