1571566 - "TypeError: cannot use a string pattern on a bytes-like object" on cmake error while building clang

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Mike Hommey [:glandium]]

When cmake fails during the clang build, the following error happens:

Traceback (most recent call last):
  File "Z:\task_1564889942\build\src/build/build-clang/build-clang.py", line 769, in <module>
    build_type, assertions, python_path, gcc_dir, libcxx_include_dir)
  File "Z:\task_1564889942\build\src/build/build-clang/build-clang.py", line 382, in build_one_stage
    build_package(build_dir, cmake_args)
  File "Z:\task_1564889942\build\src/build/build-clang/build-clang.py", line 113, in build_package
    run_in(package_build_dir, ["cmake"] + cmake_args)
  File "Z:\task_1564889942\build\src/build/build-clang/build-clang.py", line 81, in run_in
    check_run(args)
  File "Z:\task_1564889942\build\src/build/build-clang/build-clang.py", line 61, in check_run
    output_match = find_first_match(cmake_output_re)
  File "Z:\task_1564889942\build\src/build/build-clang/build-clang.py", line 57, in find_first_match
    match = re.search(l)
TypeError: cannot use a string pattern on a bytes-like object

This originates from the python3 conversion.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1571566 - Fix cmake error handling in build-clang.py after python3 conversion.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5b513cec19f
Fix cmake error handling in build-clang.py after python3 conversion. r=dmajor

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b5b513cec19f