1571603 - about:support crashes on Renesas RZ/G1 & R-Car M3

Status: NEW

(Core :: Graphics, defect, P3)

Description

[Takuro Ashie [:ashie]]

Attachment: about-support-crash.bt

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

I build firefox-68.0esr from the source and run it on Renesas R-Car M3.

Actual results:

When I open about:support page, firefox crashes with the attached back trace (for R-Car M3).

Expected results:

about:support page should be shown without crash.

Comment 1

[Takuro Ashie [:ashie]]

The proprietary driver returns nullptr on eglQueryString(nullptr, LOCAL_EGL_EXTENSIONS)) and it passed to strlen() via nsCString:

https://searchfox.org/mozilla-esr68/rev/d8f09474cf2c0cd33c147ca76b6d95f5c0965904/gfx/gl/GLContextProviderEGL.cpp#530

#ifndef ANDROID  // This query will crash some old android.
  out->AppendLiteral("\nEGL_EXTENSIONS(nullptr): ");
  out->Append((const char*)mEgl->fQueryString(nullptr, LOCAL_EGL_EXTENSIONS));
#endif
}

Comment 2

[Takuro Ashie [:ashie]]

In addition, I got similar crash bug on Renesas RZ/G1 but the context is different a bit.

Calling eglQueryString(nullptr, LOCAL_EGL_EXTENSIONS)) itself crashes on the board.
It seems same issue with bug1209612:

https://searchfox.org/mozilla-esr68/rev/d8f09474cf2c0cd33c147ca76b6d95f5c0965904/gfx/gl/GLLibraryEGL.cpp#838

#ifndef ANDROID
  // Bug 1209612: Crashes on a number of android drivers.
  // Ideally we would only blocklist this there, but for now we don't need the
  // client extension list on ANDROID (we mostly need it on ANGLE), and we'd
  // rather not crash.
  rawExtString = (const char*)fQueryString(nullptr, LOCAL_EGL_EXTENSIONS);
#endif```

Comment 3

[Takuro Ashie [:ashie]]

Attachment: 0001-Disable-eglQueryString-nullptr-EGL_EXTENSIONS.patch

Calling eglQueryString(nullptr, LOCAL_EGL_EXTENSIONS)) itself crashes on the board.

So I apply the attached ad-hoc patch to avoid crash on Yocto/OpenEmbedded, since I don't sure which drivers/platforms causes this issue.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.