1571639 - distribution.ini bookmarks are duplicated during profile refresh

Status: VERIFIED FIXED

(Firefox :: Distributions, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: duplicate_bookmarks.png

Affected versions

• 69.0b10 (20190801185445)

Affected platforms

• Windows 10x64
• Windows 10x86

Steps to reproduce

1. Install available Stub installer for any partner (eg. here) and open it.
2. Uninstall Firefox.
3. Install Firefox again (through Re-install prompt) using the link from step 1 and open it with the same profile.
4. Observe the bookmarks bar.

Expected result

• Default bookmarks are shown.

Actual result

• Default bookmarks are duplicated.

Regression range

• Not a regression, issue introduced with Stub installer for partner builds feature in 69.0b10

Additional Notes

• Every Stub reinstallation with the same profile, triggers the appearance of the same set of initial default bookmarks once more.
• Issue is not reproducible with the Full installer for partner.
• The issue is reproducible only if “Restore default settings and remove old add-ons for optimal performance” is checked.
• Attached a screenshot.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

I can get the same result by forcing a profile refresh via the safe mode dialog. What's happening is that the refresh is creating a new profile and migrating the existing bookmarks into it, but the fact that it's a new profile being created means that we also add the bookmarks from the distribution.ini, and there isn't anything checking that those bookmarks are already there.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

I don't think this is quite a duplicate of bug 1419674, but it's a similar problem with a different trigger.

Comment 3

[Mike Kaply [:mkaply]]

We have a preference that detects the bookmarks were added. Is there a way to mark prefs so they get migrated with profile refresh?

Comment 4

[Molly Howell (she/her) (mostly inactive)]

I don't see the migrator doing anything like that; I think there would have to be special support in that code for this pref.

Comment 5

[Mike Kaply [:mkaply]]

It doesn't appear the migrator can read any prefs from the previous install? I'm not sure what to do here...

Comment 6

[Mike Kaply [:mkaply]]

I'm going to take this and see what I can figure out.

We might just set the "bookmarks set" preference if it is a distro.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mkaply, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Mike Kaply [:mkaply]]

Attachment: Bug 1571639 - Don't add distro bookmarks if profile has been reset.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f827ebddcd6
Don't add distro bookmarks if profile has been reset. r=MattN

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/3f827ebddcd6

Comment 11

[Mike Kaply [:mkaply]]

Comment on attachment 9087182 [details]
Bug 1571639 - Don't add distro bookmarks if profile has been reset.

Beta/Release Uplift Approval Request

• User impact if declined: When partner builds are reset, they get duplicate bookmarks. while this was an existing issue, it became more obvious with the stub installers for partners.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: In bug (reported by QA)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects partner distributions with bookmarks.
• String changes made/needed:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9087182 [details]
Bug 1571639 - Don't add distro bookmarks if profile has been reset.

Approved for 69.0b16.

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ccdf246fedb2

Comment 14

[Anca Soncutean, Desktop QA]

This issue is verified fixed with Fx 69.0b16 on Windows 10 and Windows 7.