1571650 - Translucent parent highlighter overlays subgrid highlighter

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2019-08-06 at 11.10.31.png

With a combination of clicks users can end up in a situation where the translucent parent highlighter overlays the subgrid highlighter, resulting in blurry/unreadable line numbers.

STR:

• visit https://codepen.io/martinbalfanz/pen/qepygL
• toggle the parent highlighter div.wrapper on
• toggle the subgrid highlighter div.box.d on
• toggle the parent highlighter off

AR: the parent highlighter overlays the subgrid highlighter
ER: stacking order of highlighters should follow the nesting of the grids, with the deepest nested grid being the most visible / highest in stack / on top of the rest etc.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1571650: Add an API to change the style of AnonymousContent from devtools. r?smaug!

DevTools is using AnonymousContent to highlight the element inspecting.
And now, the z-order of highlighting became to be importance. In case of normal
element, we can change the z-order by z-index or order of DOM. However,
AnonymousContent does not have the such the way to change the z-order from
DevTools side. This patch introduces an API to change the style, and makes the
z-order changeable by the z-index.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1571650: Add test for AnonymousContent::SetStyle(). r?smaug!

In this patch, creates a test to confirm whether the AnonymousContent.setStyle()
works correctly.

Depends on D41927

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1571650: Change z-index by the nest. r?pbro!

Depends on D41928

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1571650: Add test for z-index of grids. r?pbro!

Depends on D41929

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaef1d403d31
Add an API to change the style of AnonymousContent from devtools. r=smaug
https://hg.mozilla.org/integration/autoland/rev/48438a9d64f1
Add test for AnonymousContent::SetStyle(). r=smaug
https://hg.mozilla.org/integration/autoland/rev/9f62e449f9ca
Change z-index by the nest. r=pbro
https://hg.mozilla.org/integration/autoland/rev/9c93a75bc692
Add test for z-index of grids. r=pbro

Comment 6

[Andrei Ciure[:aciure]]

Backed out 4 changesets (bug 1571650) for AddressSanitizer failures

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=261609060&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=9c93a75bc692dd3efeec21f153e90237c50c4c16

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=a3f2cf3e1bb4a9ab091f0dcf0e8eca7ed0283768&selectedJob=261597311&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-e10s-2%2Cm%282%29

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00d7377efae9
Backed out 4 changesets for AddressSanitizer failures CLOSED TREE

Comment 8

[Daisuke Akatsuka (:daisuke)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb63ca81f98acda6ec08b3e540ce9bf266bf3afc

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b08200f6ba53
Add an API to change the style of AnonymousContent from devtools. r=smaug
https://hg.mozilla.org/integration/autoland/rev/733f88623b48
Add test for AnonymousContent::SetStyle(). r=smaug
https://hg.mozilla.org/integration/autoland/rev/471f4f25da30
Change z-index by the nest. r=pbro
https://hg.mozilla.org/integration/autoland/rev/71ef696dafdc
Add test for z-index of grids. r=pbro

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b08200f6ba53
https://hg.mozilla.org/mozilla-central/rev/733f88623b48
https://hg.mozilla.org/mozilla-central/rev/471f4f25da30
https://hg.mozilla.org/mozilla-central/rev/71ef696dafdc