Closed Bug 1571650 Opened 6 months ago Closed 5 months ago

Translucent parent highlighter overlays subgrid highlighter

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: mbalfanz, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Whiteboard: [dt-q])

Attachments

(5 files)

With a combination of clicks users can end up in a situation where the translucent parent highlighter overlays the subgrid highlighter, resulting in blurry/unreadable line numbers.

STR:

AR: the parent highlighter overlays the subgrid highlighter
ER: stacking order of highlighters should follow the nesting of the grids, with the deepest nested grid being the most visible / highest in stack / on top of the rest etc.

Priority: -- → P2
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

DevTools is using AnonymousContent to highlight the element inspecting.
And now, the z-order of highlighting became to be importance. In case of normal
element, we can change the z-order by z-index or order of DOM. However,
AnonymousContent does not have the such the way to change the z-order from
DevTools side. This patch introduces an API to change the style, and makes the
z-order changeable by the z-index.

In this patch, creates a test to confirm whether the AnonymousContent.setStyle()
works correctly.

Depends on D41927

Depends on D41928

Depends on D41929

Attachment #9085381 - Attachment description: Bug 1571650: Add an API to change the style of AnonymousContent from devtools. r?pbro,smaug! → Bug 1571650: Add an API to change the style of AnonymousContent from devtools. r?smaug!
Attachment #9085382 - Attachment description: Bug 1571650: Add test for AnonymousContent::SetStyle(). r?pbro,smaug → Bug 1571650: Add test for AnonymousContent::SetStyle(). r?smaug!
Attachment #9085383 - Attachment description: Bug 1571650: Change z-index by the nest. r?pbro → Bug 1571650: Change z-index by the nest. r?pbro!
Attachment #9085385 - Attachment description: Bug 1571650: Add test for z-index of grids. r?pbro → Bug 1571650: Add test for z-index of grids. r?pbro!
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eaef1d403d31
Add an API to change the style of AnonymousContent from devtools. r=smaug
https://hg.mozilla.org/integration/autoland/rev/48438a9d64f1
Add test for AnonymousContent::SetStyle(). r=smaug
https://hg.mozilla.org/integration/autoland/rev/9f62e449f9ca
Change z-index by the nest. r=pbro
https://hg.mozilla.org/integration/autoland/rev/9c93a75bc692
Add test for z-index of grids. r=pbro
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00d7377efae9
Backed out 4 changesets for AddressSanitizer failures CLOSED TREE
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b08200f6ba53
Add an API to change the style of AnonymousContent from devtools. r=smaug
https://hg.mozilla.org/integration/autoland/rev/733f88623b48
Add test for AnonymousContent::SetStyle(). r=smaug
https://hg.mozilla.org/integration/autoland/rev/471f4f25da30
Change z-index by the nest. r=pbro
https://hg.mozilla.org/integration/autoland/rev/71ef696dafdc
Add test for z-index of grids. r=pbro
You need to log in before you can comment on or make changes to this bug.