Closed Bug 1571814 Opened 1 year ago Closed 1 year ago

Refactor attribute inheritance for CalendarListTree

Categories

(Calendar :: Tasks, task, P3)

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: pmorris, Assigned: pmorris)

References

Details

Attachments

(1 file, 1 obsolete file)

After bug 1545824 lands, follow up on bug 1504416. Use the new mechanisms for attribute inheritance, rather than doing it manually, in the CalendarListTree custom element.

See https://searchfox.org/mozilla-central/source/toolkit/content/customElements.js#393 for how this stuff works now.

The only inherited attributes we're currently using here are the ones for ".treechildren". I assume the others are there so that the inheritance is already set up to work correctly if those attributes are used in the future.

Attachment #9083741 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9083741 [details] [diff] [review]
calendar-list-tree-attribute-inheritance-0.patch

Review of attachment 9083741 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me

::: calendar/base/content/widgets/calendar-list-tree.js
@@ +19,5 @@
>       * @implements nsiTreeView
>       */
>      class CalendarListTree extends customElements.get("tree") {
> +        // The inherited attributes that are specific to CalendarListTree,
> +        // as opposed to those from the MozTree super class.

please use /** */ syntax for this documentation

@@ +51,5 @@
> +         */
> +        getElementForAttrInheritance(selector) {
> +            if (selector in CalendarListTree.calListTreeInheritedAttributes) {
> +                return this.querySelector(selector);
> +            } else {

no else after return please
Attachment #9083741 - Flags: review?(mkmelin+mozilla)
Attachment #9083741 - Flags: review?(geoff)
Attachment #9083741 - Flags: feedback+

Made the changes requested by mkmelin.

Attachment #9083741 - Attachment is obsolete: true
Attachment #9083741 - Flags: review?(geoff)
Attachment #9084017 - Flags: review?(geoff)
Status: NEW → ASSIGNED

I hate to break it to you, but this file disappeared yesterday in bug 1561530.

Huh, well, I'll be... move along, nothing to see here.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Attachment #9084017 - Flags: review?(geoff)
Resolution: FIXED → INVALID
You need to log in before you can comment on or make changes to this bug.