1571814 - Refactor attribute inheritance for CalendarListTree

Status: RESOLVED INVALID

(Calendar :: Tasks, task, P3)

Description

[Paul Morris [:pmorris]]

After bug 1545824 lands, follow up on bug 1504416. Use the new mechanisms for attribute inheritance, rather than doing it manually, in the CalendarListTree custom element.

Comment 1

[Paul Morris [:pmorris]]

Attachment: calendar-list-tree-attribute-inheritance-0.patch

See https://searchfox.org/mozilla-central/source/toolkit/content/customElements.js#393 for how this stuff works now.

The only inherited attributes we're currently using here are the ones for ".treechildren". I assume the others are there so that the inheritance is already set up to work correctly if those attributes are used in the future.

Comment 2

[Paul Morris [:pmorris]]

Try server run looks fine: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=262af2dab1cb6bc77d7902273bcdf7b64d3ac22f&selectedJob=260423052

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9083741 [details] [diff] [review]
calendar-list-tree-attribute-inheritance-0.patch

Review of attachment 9083741 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me

::: calendar/base/content/widgets/calendar-list-tree.js
@@ +19,5 @@
>       * @implements nsiTreeView
>       */
>      class CalendarListTree extends customElements.get("tree") {
> +        // The inherited attributes that are specific to CalendarListTree,
> +        // as opposed to those from the MozTree super class.

please use /** */ syntax for this documentation

@@ +51,5 @@
> +         */
> +        getElementForAttrInheritance(selector) {
> +            if (selector in CalendarListTree.calListTreeInheritedAttributes) {
> +                return this.querySelector(selector);
> +            } else {

no else after return please

Comment 4

[Paul Morris [:pmorris]]

Attachment: calendar-list-tree-attribute-inheritance-1.patch

Made the changes requested by mkmelin.

Comment 5

[Geoff Lankow (:darktrojan)]

I hate to break it to you, but this file disappeared yesterday in bug 1561530.

Comment 6

[Paul Morris [:pmorris]]

Huh, well, I'll be... move along, nothing to see here.