Handle updates for builtin extensions
Categories
(Toolkit :: Add-ons Manager, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: aswan, Assigned: aswan)
References
Details
Attachments
(1 file)
In bug 1512436 we got support for "built-in" extensions read directly from omni.ja. However, there is no current support for handling updates to these extensions (ie, when the application changes, noticing if the built-in extension has changed and needs to go through the extension update logic).
Built-in addons are currently only used for the default theme and builtin search engines which are simple enough (and change infrequently enough) that this has not been a problem. This is much more likely to become a problem if we ship full-blown extensions (e.g. screenshots) in this way.
I'm pretty sure we have to handle this within the addon manager -- the update check really needs to happen before we call startup() on builtin addons and that happens relatively early during application startup.
|
Assignee | |
Comment 2•5 years ago
|
||
As mentioned in comment 0, I don't think this is urgent for the purpose of updating the built-in search engines or themes. But this is a blocker for bug 1568270 so it should have whatever priority that effort has. Making a tentative choice for now.
|
|
Assignee | |
Comment 3•5 years ago
|
||
It looks like we're accidentally handling this: https://searchfox.org/mozilla-central/rev/158bac3df3a1890da55bdb6ffdaf9a7ffc0bfb0a/toolkit/mozapps/extensions/internal/XPIDatabase.jsm#3373-3382
In particular, we don't set a _sourceBundle property on builtin extensions, so update() gets called. We should add tests of this and perhaps clarify the code.
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
||
Updated•4 years ago
|
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Description
•