1571962 - Audit all callers of FlushPendingNotifications(FlushType::{Style|Frame})

Status: NEW

(Core :: Layout, task, P3)

Description

[u480271]

Bug 1571612 splits FlushType::Style and FlushType::Frame into different values. Audit all calls for FlushPendingNotifications(FlushType::Style) and FlushPendingNotifications(FlushType::Frame) to ensure the semantically correct value is being passed for the required behavior.

Comment 1

[u480271]

Attachment: data-review-request.txt

Comment 2

[Chris H-C :chutten]

Comment on attachment 9083538 [details]
data-review-request.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 76.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for pre-release channels only.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :kamidphish is responsible for renewing or removing the collection before it expires in Firefox 76.

---
Result: datareview+

Comment 3

[u480271]

Comment on attachment 9083538 [details]
data-review-request.txt

I accidentally attached this request but it's for bug 1571612