1571984 - GtkFileChooser doesn't preview images bigger than 4096px

Status: RESOLVED INVALID

(Core :: Widget: Gtk, enhancement, P3)

Description

[u644758]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

I tried to upload an 4920 x 3264 .jpg photo via Firefox.

Actual results:

The GtkFileChooser instance spawned by Firefox refuses to preview images bigger than 4096 pixels (mitigation for bug 1184009).

Expected results:

The preview should be generated. As gdk-pixbuf is most probably fixed by now the limit could be increased or removed altogether.

Comment 1

[Lee Salzman [:lsalzman]]

I am still not sure whether to trust GDK/GTK on this. A better alternative would probably be to rig up our own imagelib for this case, instead of relying on GDK/GTK, that way we wouldn't have to worry about future vulnerabilities or bugs...

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Yes, I agree that we should not pass so big images to GtkFileChooser.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Jan, can you look at it please?

Comment 4

[Lucien Gentis]

(In reply to Martin Stránský [:stransky] from comment #2)

Yes, I agree that we should not pass so big images to GtkFileChooser.

Hello,

System : Debian 10.6 - 64bits
Environment : Xfce 4.12
Firefox 78.4.1esr (64 bits)

I confirm the bug, but I don't think it's Gdk/Gtk related, because it is not present with Chrome or Chromium which use the same file chooser.
Thunderbird 78.4.2 (64 bits) has the same bug as Firefox.

It is annoying when you have to upload a picture to a web site like Photoweb, since most photos are yet greater than 4096 pixels width, and without a preview, it is difficult to choose the picture you want to upload.

Lucien

Comment 5

[Vitaly Zdanevich]

Attachment: gtkfilechooser-no-preview-for-big-files.jpg

Still a problem in Firefox 96, Gentoo x64.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

I understand the frustration but this isn't Firefox fault.