Closed
Bug 1571992
Opened 5 years ago
Closed 5 years ago
isScrolledToBottom isn't used properly
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
The parameter in ConsoleOutput.js#268 indicate it takes the outputNode, but the callsites pass it the last node already (ConsoleOutput.js#165,167).
This means that scrollToBottom is only true when the scrollbar is all the way to the bottom, and sometimes, if you're zoomed in, the regular flow might lose the pin-to-bottom feature.
|
Assignee | |
Comment 1•5 years ago
|
||
The function was expecting the outputNode, but the
callers pass it the outputNode lastChild.
We modify the function to work with this lastNode
instead of the outputNode.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c84c67e0d8d6 Fix isScrolledToBottom usage. r=Honza.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•