1571992 - isScrolledToBottom isn't used properly

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

The parameter in ConsoleOutput.js#268 indicate it takes the outputNode, but the callsites pass it the last node already (ConsoleOutput.js#165,167).
This means that scrollToBottom is only true when the scrollbar is all the way to the bottom, and sometimes, if you're zoomed in, the regular flow might lose the pin-to-bottom feature.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1571992 - Fix isScrolledToBottom usage. r=Honza.

The function was expecting the outputNode, but the
callers pass it the outputNode lastChild.
We modify the function to work with this lastNode
instead of the outputNode.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c84c67e0d8d6
Fix isScrolledToBottom usage. r=Honza.

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c84c67e0d8d6