1572006 - Replace use of JSRuntime with GCRuntime where possible inside the GC component

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

To increase modularity and decrease dependencies on the rest of the engine, we should prefer to pass around pointers to the GCRuntime rather than the JSRuntime within the GC component.

One example is the nursery, which has a JSRuntime* member. Most of the uses of this are of the form | runtime->gc.whatever() |, in other words we mainly use it to get at the GCRuntime. We should replace this with a GCRuntime* member.

Mostly the code is like this for historical reasons, when all the GC state used to live in the JSRuntime.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1572006 - Make Nursery store a pointer to the GCRuntime rather than the JSRuntime r?allstarschh

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1572006 - Replace use of JSRuntime in GCLock classes r?allstarschh

Depends on D48086

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1572006 - Use GCRuntime rather that JSRuntime in Chunk APIs r?allstarschh

Depends on D48087

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0f93751fd81
Make Nursery store a pointer to the GCRuntime rather than the JSRuntime r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/1748f0da5721
Replace use of JSRuntime in GCLock classes r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/886d6128768c
Use GCRuntime rather that JSRuntime in Chunk APIs r=allstarschh

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e0f93751fd81
https://hg.mozilla.org/mozilla-central/rev/1748f0da5721
https://hg.mozilla.org/mozilla-central/rev/886d6128768c

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1572006 - Make GC iterators with in terms of GCRuntime rather than JSRuntime r?allstarschh

Comment 7

[Jon Coppeard (:jonco)]

Attachment: Bug 1572006 - Make GCParallelTask work in terms of GCRuntime rather than JSRuntime r?allstarschh

Depends on D48545

Comment 8

[Jon Coppeard (:jonco)]

Attachment: Bug 1572006 - Make js::gc::Statistics work in terms of GCRuntime rather than JSRuntime r?allstarschh

Depends on D48546

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5156147aa55d
Make GC iterators with in terms of GCRuntime rather than JSRuntime r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/bd53a21e0e70
Make GCParallelTask work in terms of GCRuntime rather than JSRuntime r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/aa7957c9c241
Make js::gc::Statistics work in terms of GCRuntime rather than JSRuntime r=allstarschh

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5156147aa55d
https://hg.mozilla.org/mozilla-central/rev/bd53a21e0e70
https://hg.mozilla.org/mozilla-central/rev/aa7957c9c241

Comment 11

[Jon Coppeard (:jonco)]

A bunch of patches have landed in 71 so I'll close this and open a new bug for more work in this area.