1572013 - [BinAST] JSAPI tests for Context 0.1

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - JSAPI tests for BinAST;r?arai

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - JSAPI tests for BinAST;r?arai

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Stop masking cx_;r?arai

We have two fields cx_, one defined in the parent class and one in the child class. The latter masks the former but is uninitialized.

Getting rid of the child version.

Depends on D41176

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Initialize the vectors of HuffmanDictionary;r?arai

Depends on D42503

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Fix grammar walk order;r?arai

The walk order in the grammar is a bit unusual. Some items are treated immediately, while others are enqueued for later use (maybe this is a form of manual TCO?) This patch fixes the order to make
it match with the Python implementation.

Also, we add readUnpackedLong as some numbers are not stored as varnums.

Depends on D42845

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Strings table is written more than once in the file;r?arai

Depends on D42846

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - BinASTTokenReaderContext::readHeader is implemented, no need to pretend the contrary :);r?arai

Depends on D42847

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - BinASTTokenReaderBase::ContextPrinter;r?arai

Depends on D42848

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - A single interface type is effectively a sum with only one case;r?arai

Depends on D42849

Comment 10

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - We may now attempt to read 0 bytes;r?arai

Depends on D42850

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Calls to enterList are now properly receiving a ListContext;r?arai

Depends on D42851

Comment 12

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Making sure that the BitBuffer is initialized before we start pulling data;r?arai

Depends on D42854

Comment 13

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Shifting a uint32_t by 32 bits is UB;r?arai

Depends on D43057

Comment 14

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - enterTaggedTuple now accepts ListContext;r?arai

Depends on D43059

Comment 15

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - string enums should be in webidl order;r?arai

Depends on D43062

Comment 16

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - leadingBits should not strip quite as many bits;r?arai

Depends on D43063

Comment 17

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - AutoList::done();r?arai

Depends on D43064

Comment 18

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Handling tables with 0 bitLength;r?arai

There may be a bitLength of 0 in a table in two cases:

• a table with a single value;
• an indexed table with many values that have a probability of 0.

We refactor BinASTReaderContext::readMultipleValuesTable to handle both cases.

Depends on D43065

Comment 19

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Reading the number of symbols for a table of lists requires actually reading the number of symbols for a table of lists;r?arai

Depends on D43991

Comment 20

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - In some cases, we may end up with an empty table;r?arai

Depends on D43993

Comment 21

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Apparently, list lengths are varu32;r?arai

Depends on D43994

Comment 22

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Fixing non-0 filter in readMultipleValuesTable;r?arai

Depends on D43995

Comment 23

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Normalizing FunctionBody and FrozenArray<Statement>;r?arai

Depends on D43996

Comment 24

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - We need to recurse through lists even if we have already done this once;r?arai

Depends on D43997

Comment 25

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Implementing UnsignedLong tables;r?arai

Depends on D43998

Comment 26

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - readFieldFromTable;r?arai

Depends on D43999

Comment 27

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - readUnsignedLong needs to read from a table, not the stream;r?arai

Depends on D44000

Comment 28

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - When reading a Sum table, bailout if it's initializing;r?arai

Depends on D44001

Comment 29

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Explicit implementation of explicit tables;r?arai

Depends on D44002

Comment 30

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Entry::Dump;r?arai

Depends on D44003

Comment 31

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Zeroing out the discarded bits of the BitBuffer;r?arai

Depends on D44004

Comment 32

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Reimplementing LiteralRegExpExpression without readChars;r?arai

Depends on D44005

Comment 33

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Implementing second sorting of indexed symbols by alphanumerical order;r?arai

Depends on D44007

Comment 34

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Single-argument version of FullParseHandler::newExprStatement;r?arai

Depends on D44008

Comment 35

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - readNumberOfSymbols for MaybeString needs to read the number of symbols from the disk;r?arai

Depends on D44010

Comment 36

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Cleaning up debug code;r?arai

Depends on D44011

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1d4bc5f2132
JSAPI tests for BinAST;r=arai
https://hg.mozilla.org/integration/autoland/rev/777a5c724173
Stop masking cx_;r=arai
https://hg.mozilla.org/integration/autoland/rev/f6625272c0e7
Initialize the vectors of HuffmanDictionary;r=arai
https://hg.mozilla.org/integration/autoland/rev/eadaa128b733
Fix grammar walk order;r=arai
https://hg.mozilla.org/integration/autoland/rev/dc9be217c662
Strings table is written more than once in the file;r=arai
https://hg.mozilla.org/integration/autoland/rev/78ad3d33a1d2
BinASTTokenReaderContext::readHeader is implemented, no need to pretend the contrary :);r=arai
https://hg.mozilla.org/integration/autoland/rev/f9811a5214df
BinASTTokenReaderBase::ContextPrinter;r=arai
https://hg.mozilla.org/integration/autoland/rev/6749274ed878
A single interface type is effectively a sum with only one case;r=arai
https://hg.mozilla.org/integration/autoland/rev/9eb1c47b599c
We may now attempt to read 0 bytes;r=arai
https://hg.mozilla.org/integration/autoland/rev/b1f90b66f0ea
Calls to enterList are now properly receiving a ListContext;r=arai
https://hg.mozilla.org/integration/autoland/rev/3f5d5b751f37
Making sure that the BitBuffer is initialized before we start pulling data;r=arai
https://hg.mozilla.org/integration/autoland/rev/11b0ac933c4f
Shifting a uint32_t by 32 bits is UB;r=arai
https://hg.mozilla.org/integration/autoland/rev/b63e49274681
enterTaggedTuple now accepts ListContext;r=arai
https://hg.mozilla.org/integration/autoland/rev/117cd27efddf
string enums should be in webidl order;r=arai
https://hg.mozilla.org/integration/autoland/rev/f3c023102c92
leadingBits should not strip quite as many bits;r=arai
https://hg.mozilla.org/integration/autoland/rev/ed965128fee4
AutoList::done();r=arai
https://hg.mozilla.org/integration/autoland/rev/97cf8dc8ca31
Handling tables with 0 bitLength;r=arai
https://hg.mozilla.org/integration/autoland/rev/2f1765fbbd53
Reading the number of symbols for a table of lists requires actually reading the number of symbols for a table of lists;r=arai
https://hg.mozilla.org/integration/autoland/rev/074d3d13d212
In some cases, we may end up with an empty table;r=arai
https://hg.mozilla.org/integration/autoland/rev/cff4e008ff7d
Apparently, list lengths are varu32;r=arai
https://hg.mozilla.org/integration/autoland/rev/743f777e85b4
Fixing non-0 filter in readMultipleValuesTable;r=arai
https://hg.mozilla.org/integration/autoland/rev/af2124e68765
Normalizing FunctionBody and FrozenArray<Statement>;r=arai
https://hg.mozilla.org/integration/autoland/rev/3d91f62968d6
We need to recurse through lists even if we have already done this once;r=arai
https://hg.mozilla.org/integration/autoland/rev/04b9ddbad069
Implementing UnsignedLong tables;r=arai
https://hg.mozilla.org/integration/autoland/rev/698fdc8451aa
readFieldFromTable;r=arai
https://hg.mozilla.org/integration/autoland/rev/294a9e78a171
readUnsignedLong needs to read from a table, not the stream;r=arai
https://hg.mozilla.org/integration/autoland/rev/2e953578b8f4
When reading a Sum table, bailout if it's initializing;r=arai
https://hg.mozilla.org/integration/autoland/rev/f1c40933d56f
Explicit implementation of explicit tables;r=arai
https://hg.mozilla.org/integration/autoland/rev/557f412d3a57
Entry::Dump;r=arai
https://hg.mozilla.org/integration/autoland/rev/4219b38fc3dc
Zeroing out the discarded bits of the BitBuffer;r=arai
https://hg.mozilla.org/integration/autoland/rev/8258b9444ebf
Reimplementing LiteralRegExpExpression without readChars;r=arai
https://hg.mozilla.org/integration/autoland/rev/8b638360b151
Implementing second sorting of indexed symbols by alphanumerical order;r=arai
https://hg.mozilla.org/integration/autoland/rev/1ce3d2d06e22
Single-argument version of FullParseHandler::newExprStatement;r=arai
https://hg.mozilla.org/integration/autoland/rev/0a28e80c7477
readNumberOfSymbols for MaybeString needs to read the number of symbols from the disk;r=arai
https://hg.mozilla.org/integration/autoland/rev/82ced22da054
Cleaning up debug code;r=arai

Comment 38

[Natalia Csoregi [:nataliaCs]]

Backed out for bustages on BinASTTokenReaderContext.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/397bbb20d928970eb59c8d18cd2aa739b81cffee

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=82ced22da05477fca1f32514129d9b843e9aae21&group_state=expanded&selectedJob=264523401

failure log example: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264523401&repo=autoland&lineNumber=6443

[task 2019-09-02T09:20:02.369Z] 09:20:02 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/i18n'
[task 2019-09-02T09:20:02.447Z] 09:20:02 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src/frontend'
[task 2019-09-02T09:20:02.447Z] 09:20:02 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -o BinASTTokenReaderContext.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/frontend -I/builds/worker/workspace/build/src/obj-firefox/js/src/frontend -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -Qunused-arguments -U_FORTIFY_SOURCE -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,vla-bound -fno-sanitize-recover=bool,bounds,vla-bound -fsanitize-blacklist=/builds/worker/workspace/build/src/obj-firefox/js/src/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -MD -MP -MF .deps/BinASTTokenReaderContext.o.pp /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp
[task 2019-09-02T09:20:02.447Z] 09:20:02 ERROR - /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp:1500:40: error: no member named 'ContextPrinter' in 'js::frontend::BinASTTokenReaderBase'
[task 2019-09-02T09:20:02.447Z] 09:20:02 INFO - js::frontend::BinASTTokenReaderBase::ContextPrinter::print("bool", context);
[task 2019-09-02T09:20:02.447Z] 09:20:02 INFO - ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
[task 2019-09-02T09:20:02.447Z] 09:20:02 ERROR - /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp:1506:40: error: no member named 'ContextPrinter' in 'js::frontend::BinASTTokenReaderBase'
[task 2019-09-02T09:20:02.448Z] 09:20:02 INFO - js::frontend::BinASTTokenReaderBase::ContextPrinter::print("double", context);
[task 2019-09-02T09:20:02.448Z] 09:20:02 INFO - ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
[task 2019-09-02T09:20:02.448Z] 09:20:02 ERROR - /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp:1512:40: error: no member named 'ContextPrinter' in 'js::frontend::BinASTTokenReaderBase'
[task 2019-09-02T09:20:02.448Z] 09:20:02 INFO - js::frontend::BinASTTokenReaderBase::ContextPrinter::print("atom?", context);
[task 2019-09-02T09:20:02.448Z] 09:20:02 INFO - ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
[task 2019-09-02T09:20:02.448Z] 09:20:02 ERROR - /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp:1518:40: error: no member named 'ContextPrinter' in 'js::frontend::BinASTTokenReaderBase'
[task 2019-09-02T09:20:02.448Z] 09:20:02 INFO - js::frontend::BinASTTokenReaderBase::ContextPrinter::print("atom", context);
[task 2019-09-02T09:20:02.448Z] 09:20:02 INFO - ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
[task 2019-09-02T09:20:02.448Z] 09:20:02 ERROR - /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp:1543:40: error: no member named 'ContextPrinter' in 'js::frontend::BinASTTokenReaderBase'
[task 2019-09-02T09:20:02.448Z] 09:20:02 INFO - js::frontend::BinASTTokenReaderBase::ContextPrinter::print("variant",
[task 2019-09-02T09:20:02.448Z] 09:20:02 INFO - ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

failure log example: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264523470&repo=autoland&lineNumber=1141

[task 2019-09-02T09:14:39.253Z] In file included from /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.h:10:0,
[task 2019-09-02T09:14:39.253Z] from /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp:7:
[task 2019-09-02T09:14:39.253Z] /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp: In member function 'bool js::frontend::HuffmanPreludeReader::Boolean::lessThan(uint32_t, uint32_t)':
[task 2019-09-02T09:14:39.253Z] /builds/worker/workspace/build/src/js/src/frontend/BinASTTokenReaderContext.cpp:258:20: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
[task 2019-09-02T09:14:39.253Z] MOZ_ASSERT(0 <= aIndex && aIndex <= 1);
[task 2019-09-02T09:14:39.253Z] ~~^~~~
[task 2019-09-02T09:14:39.253Z] /builds/worker/workspace/build/src/obj-spider/dist/include/mozilla/Assertions.h:426:58: note: in definition of macro 'MOZ_VALIDATE_ASSERT_CONDITION_TYPE'
[task 2019-09-02T09:14:39.253Z] mozilla::detail::AssertionConditionType<decltype(x)>::isValid,
[task 2019-09-02T09:14:39.253Z] ^
[task 2019-09-02T09:14:39.253Z] /builds/worker/workspace/build/src/obj-spider/dist/include/mozilla/Assertions.h:463:31: note: in expansion of macro 'MOZ_ASSERT_HELPER1'
[task 2019-09-02T09:14:39.254Z] #define MOZ_ASSERT_GLUE(a, b) a b
[task 2019-09-02T09:14:39.254Z] ^
[task 2019-09-02T09:14:39.254Z] /builds/worker/workspace/build/src/obj-spider/dist/include/mozilla/Assertions.h:471:5: note: in expansion of macro 'MOZ_ASSERT_GLUE'
[task 2019-09-02T09:14:39.254Z] MOZ_ASSERT_GLUE(
[task 2019-09-02T09:14:39.254Z] ^~~~~~~~~~~~~~~

Comment 39

[David Teller [:Yoric] - still alive but not very active]

Fix in progress

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7197761bbc1f
JSAPI tests for BinAST;r=arai
https://hg.mozilla.org/integration/autoland/rev/4de367f35f6b
Stop masking cx_;r=arai
https://hg.mozilla.org/integration/autoland/rev/86ddde06ebb1
Initialize the vectors of HuffmanDictionary;r=arai
https://hg.mozilla.org/integration/autoland/rev/361b2ef32840
Fix grammar walk order;r=arai
https://hg.mozilla.org/integration/autoland/rev/0ed04e014b27
Strings table is written more than once in the file;r=arai
https://hg.mozilla.org/integration/autoland/rev/c2f00f907df1
BinASTTokenReaderContext::readHeader is implemented, no need to pretend the contrary :);r=arai
https://hg.mozilla.org/integration/autoland/rev/e53b18682926
BinASTTokenReaderBase::ContextPrinter;r=arai
https://hg.mozilla.org/integration/autoland/rev/c648bb21b689
A single interface type is effectively a sum with only one case;r=arai
https://hg.mozilla.org/integration/autoland/rev/2f5b1f54fa2e
We may now attempt to read 0 bytes;r=arai
https://hg.mozilla.org/integration/autoland/rev/941e96279d02
Calls to enterList are now properly receiving a ListContext;r=arai
https://hg.mozilla.org/integration/autoland/rev/195796967c6e
Making sure that the BitBuffer is initialized before we start pulling data;r=arai
https://hg.mozilla.org/integration/autoland/rev/c71c4512e3b3
Shifting a uint32_t by 32 bits is UB;r=arai
https://hg.mozilla.org/integration/autoland/rev/27ecfb64c36d
enterTaggedTuple now accepts ListContext;r=arai
https://hg.mozilla.org/integration/autoland/rev/b826753c74ac
string enums should be in webidl order;r=arai
https://hg.mozilla.org/integration/autoland/rev/9498469ff9a2
leadingBits should not strip quite as many bits;r=arai
https://hg.mozilla.org/integration/autoland/rev/3e41f82c421c
AutoList::done();r=arai
https://hg.mozilla.org/integration/autoland/rev/c34aeb89217a
Handling tables with 0 bitLength;r=arai
https://hg.mozilla.org/integration/autoland/rev/cc34aaa35286
Reading the number of symbols for a table of lists requires actually reading the number of symbols for a table of lists;r=arai
https://hg.mozilla.org/integration/autoland/rev/84c7e1adce7b
In some cases, we may end up with an empty table;r=arai
https://hg.mozilla.org/integration/autoland/rev/71841b42ad1e
Apparently, list lengths are varu32;r=arai
https://hg.mozilla.org/integration/autoland/rev/2b62e67acc7b
Fixing non-0 filter in readMultipleValuesTable;r=arai
https://hg.mozilla.org/integration/autoland/rev/84344ccf4e93
Normalizing FunctionBody and FrozenArray<Statement>;r=arai
https://hg.mozilla.org/integration/autoland/rev/2a74361fcb89
We need to recurse through lists even if we have already done this once;r=arai
https://hg.mozilla.org/integration/autoland/rev/44eedc9379c5
Implementing UnsignedLong tables;r=arai
https://hg.mozilla.org/integration/autoland/rev/79ac5233c546
readFieldFromTable;r=arai
https://hg.mozilla.org/integration/autoland/rev/56c384f33f17
readUnsignedLong needs to read from a table, not the stream;r=arai
https://hg.mozilla.org/integration/autoland/rev/75acff0a6dc0
When reading a Sum table, bailout if it's initializing;r=arai
https://hg.mozilla.org/integration/autoland/rev/259193353d33
Explicit implementation of explicit tables;r=arai
https://hg.mozilla.org/integration/autoland/rev/35bb047b5cb8
Entry::Dump;r=arai
https://hg.mozilla.org/integration/autoland/rev/a45b6fe08a8b
Zeroing out the discarded bits of the BitBuffer;r=arai
https://hg.mozilla.org/integration/autoland/rev/b9dedbac9386
Reimplementing LiteralRegExpExpression without readChars;r=arai
https://hg.mozilla.org/integration/autoland/rev/50421427fc6b
Implementing second sorting of indexed symbols by alphanumerical order;r=arai
https://hg.mozilla.org/integration/autoland/rev/71d65766c3a3
Single-argument version of FullParseHandler::newExprStatement;r=arai
https://hg.mozilla.org/integration/autoland/rev/4d82b252dce2
readNumberOfSymbols for MaybeString needs to read the number of symbols from the disk;r=arai
https://hg.mozilla.org/integration/autoland/rev/60950c861a6a
Cleaning up debug code;r=arai

Comment 41

[Natalia Csoregi [:nataliaCs]]

Backed out for spidermonkey bustages

backout: https://hg.mozilla.org/integration/autoland/rev/0ff0d3f2026cfe22bf6f9c90965c9381d123fbe5

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=60950c861a6a18fdcb090d04fd5e53ef65411bbf&searchStr=spidermonkey&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264567374&repo=autoland&lineNumber=85609 mozcrash.py | application crashed [@ js::frontend::HuffmanDictionary::HuffmanDictionary]

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264567319&repo=autoland&lineNumber=44509

Comment 42

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - HuffmanDictionary::listLengths is only meant to contain BINAST_NUMBER_OF_LIST_TYPES elements;r?arai

Comment 43

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - HuffmanDictionary::HuffmanDictionary needs to reserve() its space dynamically, in addition to statically;r?arai

Comment 44

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1572013 - Use infallibleEmplaceBack in HuffmanDictionary;r?arai

Comment 45

[Tooru Fujisawa [:arai]]

Attachment: Bug 1572013 - Use raw newline in multi-line strings in binast/src/main.rs. r?Yoric

Comment 46

[Tooru Fujisawa [:arai]]

Attachment: Bug 1572013 - Generate macro for mozilla::Array constructor parmeters. r?Yoric

Depends on D44446

Comment 47

[Tooru Fujisawa [:arai]]

Attachment: Bug 1572013 - Use mozilla::Array instead of mozilla::Vector for static array. r?Yoric

Depends on D44447

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dfad95bed3f
JSAPI tests for BinAST;r=arai
https://hg.mozilla.org/integration/autoland/rev/3cb2fff3d579
Stop masking cx_;r=arai
https://hg.mozilla.org/integration/autoland/rev/ea9d11b1de26
Initialize the vectors of HuffmanDictionary;r=arai
https://hg.mozilla.org/integration/autoland/rev/311464453805
Fix grammar walk order;r=arai
https://hg.mozilla.org/integration/autoland/rev/e682b2f9c9ce
Strings table is written more than once in the file;r=arai
https://hg.mozilla.org/integration/autoland/rev/d4be24fa94d9
BinASTTokenReaderContext::readHeader is implemented, no need to pretend the contrary :);r=arai
https://hg.mozilla.org/integration/autoland/rev/322b17d6eef5
BinASTTokenReaderBase::ContextPrinter;r=arai
https://hg.mozilla.org/integration/autoland/rev/8aafb1824b69
A single interface type is effectively a sum with only one case;r=arai
https://hg.mozilla.org/integration/autoland/rev/022f88ea4585
We may now attempt to read 0 bytes;r=arai
https://hg.mozilla.org/integration/autoland/rev/308af78094fc
Calls to enterList are now properly receiving a ListContext;r=arai
https://hg.mozilla.org/integration/autoland/rev/52a4f2cb9e11
Making sure that the BitBuffer is initialized before we start pulling data;r=arai
https://hg.mozilla.org/integration/autoland/rev/728f89f91abb
Shifting a uint32_t by 32 bits is UB;r=arai
https://hg.mozilla.org/integration/autoland/rev/ab76ac36b109
enterTaggedTuple now accepts ListContext;r=arai
https://hg.mozilla.org/integration/autoland/rev/11f3eed48563
string enums should be in webidl order;r=arai
https://hg.mozilla.org/integration/autoland/rev/ff8deebd0d44
leadingBits should not strip quite as many bits;r=arai
https://hg.mozilla.org/integration/autoland/rev/2953c4bd0d4f
AutoList::done();r=arai
https://hg.mozilla.org/integration/autoland/rev/03d1805862ac
Handling tables with 0 bitLength;r=arai
https://hg.mozilla.org/integration/autoland/rev/8feea4c2ed07
Reading the number of symbols for a table of lists requires actually reading the number of symbols for a table of lists;r=arai
https://hg.mozilla.org/integration/autoland/rev/d975bcbe5d19
In some cases, we may end up with an empty table;r=arai
https://hg.mozilla.org/integration/autoland/rev/f5bdc434b0ec
Apparently, list lengths are varu32;r=arai
https://hg.mozilla.org/integration/autoland/rev/b8c73a65a7b2
Fixing non-0 filter in readMultipleValuesTable;r=arai
https://hg.mozilla.org/integration/autoland/rev/cab31344b9a6
Normalizing FunctionBody and FrozenArray<Statement>;r=arai
https://hg.mozilla.org/integration/autoland/rev/d23f87fc9e60
We need to recurse through lists even if we have already done this once;r=arai
https://hg.mozilla.org/integration/autoland/rev/181c6f9a33ef
Implementing UnsignedLong tables;r=arai
https://hg.mozilla.org/integration/autoland/rev/c4ae36b55728
readFieldFromTable;r=arai
https://hg.mozilla.org/integration/autoland/rev/eb7594e2baf7
readUnsignedLong needs to read from a table, not the stream;r=arai
https://hg.mozilla.org/integration/autoland/rev/199ed1d5cbc6
When reading a Sum table, bailout if it's initializing;r=arai
https://hg.mozilla.org/integration/autoland/rev/26c0da4534ae
Explicit implementation of explicit tables;r=arai
https://hg.mozilla.org/integration/autoland/rev/83a18fcc8f8e
Entry::Dump;r=arai
https://hg.mozilla.org/integration/autoland/rev/9a0e76727726
Zeroing out the discarded bits of the BitBuffer;r=arai
https://hg.mozilla.org/integration/autoland/rev/f89932a36bc3
Reimplementing LiteralRegExpExpression without readChars;r=arai
https://hg.mozilla.org/integration/autoland/rev/4cc240516fd1
Implementing second sorting of indexed symbols by alphanumerical order;r=arai
https://hg.mozilla.org/integration/autoland/rev/66d0eb700d8c
Single-argument version of FullParseHandler::newExprStatement;r=arai
https://hg.mozilla.org/integration/autoland/rev/0f01a42e013b
readNumberOfSymbols for MaybeString needs to read the number of symbols from the disk;r=arai
https://hg.mozilla.org/integration/autoland/rev/229fa6df8c45
Cleaning up debug code;r=arai
https://hg.mozilla.org/integration/autoland/rev/cd6c35119fba
HuffmanDictionary::listLengths is only meant to contain BINAST_NUMBER_OF_LIST_TYPES elements;r=arai
https://hg.mozilla.org/integration/autoland/rev/1a9d471d259b
Use infallibleEmplaceBack in HuffmanDictionary;r=arai
https://hg.mozilla.org/integration/autoland/rev/7f9c7a2b4785
Use raw newline in multi-line strings in binast/src/main.rs. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/e379722a96b5
Generate macro for mozilla::Array constructor parmeters. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/0035d6155a75
Use mozilla::Array instead of mozilla::Vector for static array. r=Yoric

Comment 49

[Andreea Pavel [:apavel]]

Backed out for SM build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=264714679&resultStatus=testfailed%2Cbusted%2Cexception&revision=0035d6155a75c8c2d9446bb322ac31cfd705a6ee

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264714679&repo=autoland&lineNumber=44372

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264714739&repo=autoland&lineNumber=85689

Backout: https://hg.mozilla.org/integration/autoland/rev/bff5b6ee3f835ae83a1f43cd2ac924195e31a351

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c4201771f69
JSAPI tests for BinAST;r=arai
https://hg.mozilla.org/integration/autoland/rev/6861bcd9334e
Stop masking cx_;r=arai
https://hg.mozilla.org/integration/autoland/rev/a8915d370390
Initialize the vectors of HuffmanDictionary;r=arai
https://hg.mozilla.org/integration/autoland/rev/1837e5c1b1b2
Fix grammar walk order;r=arai
https://hg.mozilla.org/integration/autoland/rev/a66e5328d99f
Strings table is written more than once in the file;r=arai
https://hg.mozilla.org/integration/autoland/rev/bdaa46d9955b
BinASTTokenReaderContext::readHeader is implemented, no need to pretend the contrary :);r=arai
https://hg.mozilla.org/integration/autoland/rev/1da2f144426c
BinASTTokenReaderBase::ContextPrinter;r=arai
https://hg.mozilla.org/integration/autoland/rev/4d8366e093fa
A single interface type is effectively a sum with only one case;r=arai
https://hg.mozilla.org/integration/autoland/rev/b77d7ca251ff
We may now attempt to read 0 bytes;r=arai
https://hg.mozilla.org/integration/autoland/rev/3c9638c5654d
Calls to enterList are now properly receiving a ListContext;r=arai
https://hg.mozilla.org/integration/autoland/rev/68c88329e9e8
Making sure that the BitBuffer is initialized before we start pulling data;r=arai
https://hg.mozilla.org/integration/autoland/rev/bb9aae5006a9
Shifting a uint32_t by 32 bits is UB;r=arai
https://hg.mozilla.org/integration/autoland/rev/23e0eff414e5
enterTaggedTuple now accepts ListContext;r=arai
https://hg.mozilla.org/integration/autoland/rev/89fb53191ead
string enums should be in webidl order;r=arai
https://hg.mozilla.org/integration/autoland/rev/1059911f52e0
leadingBits should not strip quite as many bits;r=arai
https://hg.mozilla.org/integration/autoland/rev/5e990a84bf6c
AutoList::done();r=arai
https://hg.mozilla.org/integration/autoland/rev/9e39e5cc0317
Handling tables with 0 bitLength;r=arai
https://hg.mozilla.org/integration/autoland/rev/147b05de5721
Reading the number of symbols for a table of lists requires actually reading the number of symbols for a table of lists;r=arai
https://hg.mozilla.org/integration/autoland/rev/7dd8428314db
In some cases, we may end up with an empty table;r=arai
https://hg.mozilla.org/integration/autoland/rev/7ed60dd2b1da
Apparently, list lengths are varu32;r=arai
https://hg.mozilla.org/integration/autoland/rev/4462b5cdadb2
Fixing non-0 filter in readMultipleValuesTable;r=arai
https://hg.mozilla.org/integration/autoland/rev/9bfa819e3aca
Normalizing FunctionBody and FrozenArray<Statement>;r=arai
https://hg.mozilla.org/integration/autoland/rev/0104f04b7a0e
We need to recurse through lists even if we have already done this once;r=arai
https://hg.mozilla.org/integration/autoland/rev/cdd32ee1362d
Implementing UnsignedLong tables;r=arai
https://hg.mozilla.org/integration/autoland/rev/7905ca0d74d1
readFieldFromTable;r=arai
https://hg.mozilla.org/integration/autoland/rev/3abf41b283f1
readUnsignedLong needs to read from a table, not the stream;r=arai
https://hg.mozilla.org/integration/autoland/rev/f867c4876903
When reading a Sum table, bailout if it's initializing;r=arai
https://hg.mozilla.org/integration/autoland/rev/46f8a0637ae0
Explicit implementation of explicit tables;r=arai
https://hg.mozilla.org/integration/autoland/rev/3cb7aa3a7300
Entry::Dump;r=arai
https://hg.mozilla.org/integration/autoland/rev/188cf41e5f81
Zeroing out the discarded bits of the BitBuffer;r=arai
https://hg.mozilla.org/integration/autoland/rev/91c3a4db85ee
Reimplementing LiteralRegExpExpression without readChars;r=arai
https://hg.mozilla.org/integration/autoland/rev/7e9669d8202d
Implementing second sorting of indexed symbols by alphanumerical order;r=arai
https://hg.mozilla.org/integration/autoland/rev/3c33e0331c98
Single-argument version of FullParseHandler::newExprStatement;r=arai
https://hg.mozilla.org/integration/autoland/rev/27581d303b32
readNumberOfSymbols for MaybeString needs to read the number of symbols from the disk;r=arai
https://hg.mozilla.org/integration/autoland/rev/4acf3523ee6a
Cleaning up debug code;r=arai
https://hg.mozilla.org/integration/autoland/rev/1440b194e922
HuffmanDictionary::listLengths is only meant to contain BINAST_NUMBER_OF_LIST_TYPES elements;r=arai
https://hg.mozilla.org/integration/autoland/rev/0c55fd936d60
Use infallibleEmplaceBack in HuffmanDictionary;r=arai
https://hg.mozilla.org/integration/autoland/rev/3620a800cc66
Use raw newline in multi-line strings in binast/src/main.rs. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/8ee77eca36ad
Generate macro for mozilla::Array constructor parmeters. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/f97dcd69b564
Use mozilla::Array instead of mozilla::Vector for static array. r=Yoric

Comment 51

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5c4201771f69
https://hg.mozilla.org/mozilla-central/rev/6861bcd9334e
https://hg.mozilla.org/mozilla-central/rev/a8915d370390
https://hg.mozilla.org/mozilla-central/rev/1837e5c1b1b2
https://hg.mozilla.org/mozilla-central/rev/a66e5328d99f
https://hg.mozilla.org/mozilla-central/rev/bdaa46d9955b
https://hg.mozilla.org/mozilla-central/rev/1da2f144426c
https://hg.mozilla.org/mozilla-central/rev/4d8366e093fa
https://hg.mozilla.org/mozilla-central/rev/b77d7ca251ff
https://hg.mozilla.org/mozilla-central/rev/3c9638c5654d
https://hg.mozilla.org/mozilla-central/rev/68c88329e9e8
https://hg.mozilla.org/mozilla-central/rev/bb9aae5006a9
https://hg.mozilla.org/mozilla-central/rev/23e0eff414e5
https://hg.mozilla.org/mozilla-central/rev/89fb53191ead
https://hg.mozilla.org/mozilla-central/rev/1059911f52e0
https://hg.mozilla.org/mozilla-central/rev/5e990a84bf6c
https://hg.mozilla.org/mozilla-central/rev/9e39e5cc0317
https://hg.mozilla.org/mozilla-central/rev/147b05de5721
https://hg.mozilla.org/mozilla-central/rev/7dd8428314db
https://hg.mozilla.org/mozilla-central/rev/7ed60dd2b1da
https://hg.mozilla.org/mozilla-central/rev/4462b5cdadb2
https://hg.mozilla.org/mozilla-central/rev/9bfa819e3aca
https://hg.mozilla.org/mozilla-central/rev/0104f04b7a0e
https://hg.mozilla.org/mozilla-central/rev/cdd32ee1362d
https://hg.mozilla.org/mozilla-central/rev/7905ca0d74d1
https://hg.mozilla.org/mozilla-central/rev/3abf41b283f1
https://hg.mozilla.org/mozilla-central/rev/f867c4876903
https://hg.mozilla.org/mozilla-central/rev/46f8a0637ae0
https://hg.mozilla.org/mozilla-central/rev/3cb7aa3a7300
https://hg.mozilla.org/mozilla-central/rev/188cf41e5f81
https://hg.mozilla.org/mozilla-central/rev/91c3a4db85ee
https://hg.mozilla.org/mozilla-central/rev/7e9669d8202d
https://hg.mozilla.org/mozilla-central/rev/3c33e0331c98
https://hg.mozilla.org/mozilla-central/rev/27581d303b32
https://hg.mozilla.org/mozilla-central/rev/4acf3523ee6a
https://hg.mozilla.org/mozilla-central/rev/1440b194e922
https://hg.mozilla.org/mozilla-central/rev/0c55fd936d60
https://hg.mozilla.org/mozilla-central/rev/3620a800cc66
https://hg.mozilla.org/mozilla-central/rev/8ee77eca36ad
https://hg.mozilla.org/mozilla-central/rev/f97dcd69b564