1572173 - Send `addon_install_method` values for abuse reports without pre-classification

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Due to restrictions in the AMO API, Firefox classifies the addon_install_method value intro predefined values, and whenever the value doesn't fix a classification, Firefox will put it into the "Other" bucket.

In order to be more flexible, we would like Firefox to send the value without pre-classification. Making the API more flexible and accept any values is being handled on this issue.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1572173 - AbuseReporter should send addon install source and method without pre-classification. r?mixedpuppy!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8538d6d9b31
AbuseReporter should send addon install source and method without pre-classification. r=mixedpuppy

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c8538d6d9b31

Comment 4

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm marking this as qe-verify+, because this change has to be verified on the additional changes required on the AMO side (https://github.com/mozilla/addons-server/issues/12060 and https://github.com/mozilla/addons-server/pull/12190).

To be able to verify this bug, the related AMO change should have been deployed to the addons-dev.allizom.org environment.

The STR to use should be based on the one we used to originally verify the "integrated abuse report panel" feature on Firefox 68, I'm adding a needinfo assigned to :VictorC to get the details related to the original QA testplan.

The original STR should be mostly unchanged, the only difference should be how the new addon_install_source and addon_install_method values are being categorized by the API endpoint, I'm adding a needinfo assigned to :mat to get some additional details about what values we expect on the AMO side.

Comment 6

[Mathieu Pillard [:mat]]

AMO dev (and stage in a few hours from now) should now support all possible current values for install source&method, and this should be reflected in the admin when viewing abuse reports.

Comment 7

[Victor Carciu]

Verified the issue in FF70 using AMO-dev, with following results:

1. Installation from Recommended section in about:addons(webext+themes) :

   • Addon install method : none
   • Addon install source : Disco Pane

2. Installation with drag and drop :

   • Addon install method : none
   • Addon install source : file URL

3. Installation from AMO(webext+themes) :

   • Addon install method : Addon manager webapi
   • Addon install source : Other

4. Installation from file

   • Addon install method : from file
   • Addon install source : Addon manager

5. Install from Return to AMO

   • Addon install method : none
   • Addon install source : RTAMO

6. Install from about:debugging

   • Addon install method : none
   • Addon install source : Temporary addon

7. Sideloading

   • Addon install method : Sideload
   • Addon install source : App Profile

8. Install from 3rd party

   • Addon install method : Direct link
   • Addon install source : Unknown

After checking all these results with Luca Greco on slack , I will mark the issue as verified.