1572243 - Safebrowsing site warning bar disappears when tab is moved to new window, and stops showing future warnings

Status: NEW

(Toolkit :: Safe Browsing, defect, P3)

Description

[13hu]

FF 68.0.1
macOS 10.14.6

Open tab in existing window

• https://testsafebrowsing.appspot.com/s/phishing.html
• See details, ignore risk and continue
• red warning bar should appear
• now drag the tab out to a new window

The warning bar disappears after dragging tab to a new window
Also after moving the window and revisiting https://testsafebrowsing.appspot.com/s/phishing.html and other https://testsafebrowsing.appspot.com/ pages , no Safe browsing warnings are given, not even the initial one.

Expected: warnings remain independent of tab windowing

Comment 1

[Dimi Lee [:dimi]]

This bug contains two issues:

1. We don't show the warning bar again for URLs have already been set "ignore risk" before.
2. #1 also applies to other URLs under the same domain. This is because when we ignore risk, we grant permission[1] based on the origin[2], not the exact URL.

For #1, the possible solutions are:

1. Always show the warning page so if users want to continue, they need to set "ignore risk" every time (This is also how Chrome does)
2. Detect if a URL has been set "ignore risk" before, if it has, shows the warning bar.

As for issue #2, the solution depends on which option we take for issue #1, if it is the first option(always show the warning page while revisiting), then there is no problem for this.

[1] https://searchfox.org/mozilla-central/rev/c7e8bc4996f979e5876b33afae3de3b1ab4f3ae1/browser/base/content/browser.js#3753
[2] https://searchfox.org/mozilla-central/rev/c7e8bc4996f979e5876b33afae3de3b1ab4f3ae1/extensions/permissions/nsPermissionManager.cpp#2225

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dimi, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[nicoleta.sibisan]

Safebrowsing site warning bar still disappears when tab is moved to new window.
Issue reproduced on MacOS 12, Win 11 and Ubuntu 22.04 with Fx versions: 102.11.0esr, 113.0, 114.0b3, and latest Nightly 115.0a1 (2023-05-11).

Similar issue: bug 1349774