Closed
Bug 1572262
Opened 6 years ago
Closed 6 years ago
Fix background colours of new calendar list with themes
Categories
(Calendar :: General, task)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 70.0
People
(Reporter: darktrojan, Assigned: Paenglab)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.36 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
This is the follow-up bug from bug 1561530 comment 5.
|
Assignee | |
Comment 1•6 years ago
|
||
This fixes the colour issues with themes. Try the dark theme and you see the difference.
Some unrelated lines had 4 space indentation -> fixed.
I also added sibling selectors to make it for the CSS/DOM walker (or how its name is) clearer and faster.
Attachment #9084543 -
Flags: review?(geoff)
|
||
Updated•6 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9084543 [details] [diff] [review]
1572262-calendar-list-theme-fixes.patch
Okay, that looks better, thanks. A good call on the selectors too.
I think we should move the LWT stuff down the file to be with the rules it's overriding. I've been meaning to add a comment to that part warning about there being multiple uses of `#calendar-list-pane`, so it would be helpful if all of it was together.
Attachment #9084543 -
Flags: review?(geoff) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Moved the stuff down after the other #calendar-list > richlistitem rules.
Attachment #9084543 -
Attachment is obsolete: true
Attachment #9084596 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ef868ddafb00
Fix background colours of new calendar list with themes. r=darktrojan DONTBUILD
|
|
||
Updated•6 years ago
|
Target Milestone: --- → 70
You need to log in
before you can comment on or make changes to this bug.
Description
•