1572421 - Display list dump does not include all items

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Miko Mynttinen]

It seems that the current WR DL dump does not include all the serialized items. I think this might be caused by mBuilderDumpIndex being incremented wrong.

Testcase: data:text/html,test

Attached

1. current WR DL dump
2. "raw" WR DL dump (all the serialized items)
3. patch to dump all serialized items.

Comment 1

[Miko Mynttinen]

Attachment: wr-dl-dump.txt

Comment 2

[Miko Mynttinen]

Attachment: raw_items.txt

Comment 3

[Miko Mynttinen]

Attachment: wr-raw-dl-dump.patch

Comment 5

[Kartikaya Gupta (email:[e-mail])]

This was never actually fixed; bug 1616335 just added a new dumping mechanism that didn't have this problem. With bug 1652986 fixed this problem comes back for the interleaved dumping mechanism enabled by gfx.webrender.dl.dump-content.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

This happens because when the display list is properly finalized, it tacks on a "red zone" at the end of the data buffer, here. But when we make the "fake finalized" display list for printing purposes (here) we don't append the red zone, and so the iterator bails out here until enough stuff has been added to the data buffer. So I guess this was regressed by the switch over to peek-poke.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1572421 - Tack on a temporary red zone to the data buffer for iteration. r?miko

When iterating a "built display list" the iterator expects there to be a red
zone at the end of the data buffer. The incremental display list emitter fakes
having a built display list, but it still needs to tack on the red zone to
satisfy the iterator (and assertions inside peek-poke). However we don't want
to keep this red zone there after we're done, so this patch also adds a new
method to peek-poke that strips away the red zone. The churn caused on the
vector capacity should be negligible because this churn would happen
anyway as new items are added to the display list and when the display list
is actually finalized at the end.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abb94818ea0d
Tack on a temporary red zone to the data buffer for iteration. r=miko

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/abb94818ea0d