1572468 - Add telemetryId's to engines.json

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Dale Harvey (:daleharvey)]

As a follow up to https://bugzilla.mozilla.org/show_bug.cgi?id=1542243

Comment 1

[Dale Harvey (:daleharvey)]

So I will leave this open until we are all sure but I dont think this is necessary, we can still generate the same shortName using the new configuration format

Comment 2

[Mark Banner (:standard8)]

(In reply to Dale Harvey (:daleharvey) from comment #1)

So I will leave this open until we are all sure but I dont think this is necessary, we can still generate the same shortName using the new configuration format

I think we should add the telemetryId - when we are able to start re-arranging some of the search add-ons (e.g. merge locales or rename them), I think we're going to need it. Adding it at this stage will give us a simple way to verify that we're reporting the id that we expect.

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1572468 - Add telemetryIds to modern config.

Comment 4

[Dale Harvey (:daleharvey)]

So the above patch matches the modern configuration telemetryIds with the ones list.json will us. Its a simple field we need to add to every configuration we want to distinguish in telemetry

Mike Connor I only matched the telemetryId's for the 6 engines we test, mostly because if we are that bothered about getting it right we should add tests for it and we only have tests for those engines, this means twitter / wikipedia will report as "twitter" and not "twitter-jp" etc, is that ok?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/365f3fcf9ba1
Add telemetryIds to modern config. r=Standard8

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/365f3fcf9ba1

Comment 7

[Mark Banner (:standard8)]

(In reply to Dale Harvey (:daleharvey) from comment #4)

So the above patch matches the modern configuration telemetryIds with the ones list.json will us. Its a simple field we need to add to every configuration we want to distinguish in telemetry

Mike Connor I only matched the telemetryId's for the 6 engines we test, mostly because if we are that bothered about getting it right we should add tests for it and we only have tests for those engines, this means twitter / wikipedia will report as "twitter" and not "twitter-jp" etc, is that ok?

Mike answered this elsewhere and commented that this was fine.