1572528 - [Protections Panel] Update category item subviews

Status: VERIFIED FIXED

(Firefox :: Site Identity, task, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

1. Update list item styling
2. Update titles
3. Add descriptions

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1572528 - [Protections Panel] Update category item subviews. r=johannh

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1572528 - Update cookies subview test. r=johannh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7737e46df84
[Protections Panel] Update category item subviews. r=johannh
https://hg.mozilla.org/integration/autoland/rev/50d7db79ee2f
Update cookies subview test. r=johannh

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e7737e46df84
https://hg.mozilla.org/mozilla-central/rev/50d7db79ee2f

Comment 5

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello Nihanth,

All the specified elements have been added in the latest FF Nightly 70.0a1 (2019-08-19). Verified using Windows 10x64,macOS 10.14 and Ubuntu 18.04.

However I did notice some discrepancies between what is inside the browser and what is inside the Tracking Protection Panel design documentation from : https://mozilla.invisionapp.com/share/RARKT5F7KDH#/screens/360900829.

The aforementioned discrepancies are as follows:

-Titles of the sections are not the same as in the design document ("Blocking Fingerprinters" in design doc versus "Fingerprinters Blocked" inside the browser

• Descriptions of Fingerprints ,Social media trackers, Cross Site Tracking cookies are not as displayed inside the design document.

Could you please confirm if this is intended?

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Vlad Lucaci, QA (:vlucaci) from comment #5)

Hello Nihanth,

All the specified elements have been added in the latest FF Nightly 70.0a1 (2019-08-19). Verified using Windows 10x64,macOS 10.14 and Ubuntu 18.04.

However I did notice some discrepancies between what is inside the browser and what is inside the Tracking Protection Panel design documentation from : https://mozilla.invisionapp.com/share/RARKT5F7KDH#/screens/360900829.

The aforementioned discrepancies are as follows:

-Titles of the sections are not the same as in the design document ("Blocking Fingerprinters" in design doc versus "Fingerprinters Blocked" inside the browser

• Descriptions of Fingerprints ,Social media trackers, Cross Site Tracking cookies are not as displayed inside the design document.

Could you please confirm if this is intended?

Hi Vlad, thanks for looking into this!

Actually, the Invision spec is not the source of truth for strings. For strings, please refer to https://docs.google.com/presentation/d/14-AIQWnDDHO1pYhHDZffJ2x4gWT7VkCSkb-X3ghmfKA/edit#slide=id.g574454e3dd_0_60

Please let me know if there are other people with whom I should share this document. Thanks!

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Thank you!

Confirming this issue as verified fixed on 70.0a1 (2019-08-19) with Windows 10x64 , Ubuntu 18.04 and macOS 10.14.6. .
The newly implemented content is according to both the UI and strings documentation provided.