Closed Bug 1572528 Opened 3 months ago Closed 2 months ago

[Protections Panel] Update category item subviews

Categories

(Firefox :: Site Identity, task, P1)

task

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox70 --- verified

People

(Reporter: nhnt11, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [privacy-panel][skyline])

Attachments

(2 files)

  1. Update list item styling
  2. Update titles
  3. Add descriptions
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e7737e46df84
[Protections Panel] Update category item subviews. r=johannh
https://hg.mozilla.org/integration/autoland/rev/50d7db79ee2f
Update cookies subview test. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Hello Nihanth,

All the specified elements have been added in the latest FF Nightly 70.0a1 (2019-08-19). Verified using Windows 10x64,macOS 10.14 and Ubuntu 18.04.

However I did notice some discrepancies between what is inside the browser and what is inside the Tracking Protection Panel design documentation from : https://mozilla.invisionapp.com/share/RARKT5F7KDH#/screens/360900829.

The aforementioned discrepancies are as follows:

-Titles of the sections are not the same as in the design document ("Blocking Fingerprinters" in design doc versus "Fingerprinters Blocked" inside the browser

  • Descriptions of Fingerprints ,Social media trackers, Cross Site Tracking cookies are not as displayed inside the design document.

Could you please confirm if this is intended?

Flags: needinfo?(nhnt11)

(In reply to Vlad Lucaci, QA (:vlucaci) from comment #5)

Hello Nihanth,

All the specified elements have been added in the latest FF Nightly 70.0a1 (2019-08-19). Verified using Windows 10x64,macOS 10.14 and Ubuntu 18.04.

However I did notice some discrepancies between what is inside the browser and what is inside the Tracking Protection Panel design documentation from : https://mozilla.invisionapp.com/share/RARKT5F7KDH#/screens/360900829.

The aforementioned discrepancies are as follows:

-Titles of the sections are not the same as in the design document ("Blocking Fingerprinters" in design doc versus "Fingerprinters Blocked" inside the browser

  • Descriptions of Fingerprints ,Social media trackers, Cross Site Tracking cookies are not as displayed inside the design document.

Could you please confirm if this is intended?

Hi Vlad, thanks for looking into this!

Actually, the Invision spec is not the source of truth for strings. For strings, please refer to https://docs.google.com/presentation/d/14-AIQWnDDHO1pYhHDZffJ2x4gWT7VkCSkb-X3ghmfKA/edit#slide=id.g574454e3dd_0_60

Please let me know if there are other people with whom I should share this document. Thanks!

Flags: needinfo?(nhnt11)

Thank you!

Confirming this issue as verified fixed on 70.0a1 (2019-08-19) with Windows 10x64 , Ubuntu 18.04 and macOS 10.14.6. .
The newly implemented content is according to both the UI and strings documentation provided.

Status: RESOLVED → VERIFIED
Regressions: 1575859
Depends on: 1579730
You need to log in before you can comment on or make changes to this bug.