1572596 - Resurrect GC'ed sources when attaching the debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Brian Hackett [Laid off!]]

Attachment: WIP

As described in bug 1571592, the debugger should be able to show sources that were loaded into its target but have since been GC'ed along with all their contents. The strategy here is to keep track of the URLs that have been loaded into each non-system-zone realm, so that the debugger can query the information later even if it wasn't attached when the URL was loaded. The attached patch makes this change, limiting the number of URLs to 100 per realm and the URL length to 1024 to keep memory from getting out of control if there are lots of URLs or very long URLs (like data URLs). The URLs are purged on compacting GCs, which happen when there is memory pressure or the user has been idle a while, and shouldn't affect typical debugger use cases.

This patch is a WIP because for sources in HTML files it scans the file for potential inline scripts using some simple regexps. I'm going to try a little harder to see if this can be avoided.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1572596 Part 1 - Add source URLs slot to global objects which is cleared on shrinking GC, r=jonco.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1572596 Part 2 - Add debugger APIs to get the URLs associated with debuggee realms, and to create new sources, r=jimb.

Depends on D41682

Comment 3

[Brian Hackett [Laid off!]]

Attachment: Bug 1572596 Part 3 - Resurrect any sources missing from the debuggee source URLs when attaching the debugger, r=loganfsmyth.

Depends on D41683

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaaa162990a6
Part 1 - Add source URLs slot to global objects which is cleared on shrinking GC, r=jonco.
https://hg.mozilla.org/integration/autoland/rev/492f6f5065e2
Part 2 - Add debugger APIs to get the URLs associated with debuggee realms, and to create new sources, r=jimb.
https://hg.mozilla.org/integration/autoland/rev/6b12a87f2d4a
Part 3 - Resurrect any sources missing from the debuggee source URLs when attaching the debugger, r=loganfsmyth.

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/aaaa162990a6
https://hg.mozilla.org/mozilla-central/rev/492f6f5065e2
https://hg.mozilla.org/mozilla-central/rev/6b12a87f2d4a