1572793 - Connecting to a webextensions running in a remote Fennec target fails because webextension-fallback.html is missing

Status: VERIFIED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Connecting from about:debugging to a webextension running in a remote Fennec target is currently failing (the toolbox is actually opened but it fails to be fully initialized) because chrome://devtools/content/shared/webextension-fallback.html doesn't seem to be currently available in a non-desktop build.

Comment 1

[:Gijs (he/him)]

This file should be packaged in shared/server, but I didn't see an obvious way to do that, because they seem to use DevtoolsModules in moz.build files instead of jar.mn, and because this isn't a devtools module adding the html file as one seemed wrong. I didn't think it mattered when I wrote the patch, as I figured it's always the client that loads it - but that's wrong, the file is loaded by the devtools server, so the current state of the world is broken when connecting to a fennec server from a desktop client. :-(

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1572793 - Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r?jdescottes!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2688d6a1017
Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r=jdescottes

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a2688d6a1017

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9085395 [details]
Bug 1572793 - Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r?jdescottes!

Beta/Release Uplift Approval Request

• User impact if declined: Extension developers may be unable to connect a devtools toolbox from about:debugging to a webextension running in a remote Fennec instance (if the Fennec instance with a release version >= 69).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Run a Fennec instance with a release version >= 69 (it may be available from the assets collected from the build infrastructure, I'm not sure if any of the official Fennec/Firefox for Android builds is being build from anything more recent than 68) in an android emulator or test device

• install an extension on Fennec from AMO
• enable remove debugging over USB (from Fennec settings)
• open about:debugging in a recent Nightly Firefox Desktop instance (on the same machine that started the emulator, or the test device over USB)
• Enable USB devices
• click the "Connect" button related to the remote Fennec running in the android emulator or test device (once it appears in the about:debugging left sidebar, if it doesn't press the "Refresh devices" button) and once connected click on the entry in the sidebar
• in the "Extensions" list look for the extension installed from AMO and click the "Inspect" button

Expected behavior:

• it opens a devtools toolbox connected to the remote extension and the devtools toolbox is correctly rendered and provide all the expected devtools panels

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is pretty small, it moves the fallback.html page into the "devtools shared" resources (which are available in both desktop and mobile builds).
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9085395 [details]
Bug 1572793 - Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r?jdescottes!

Fixes a devtools regression in Fx69. Approved for 69.0b16.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/79ab9ee7d7e9

Comment 9

[Laurentiu Apahidean]

I have tested the issue on the latest Firefox builds: 69.0b16 and 70.0a1 (2019-08-22) using a Samsung Galaxy S8+ (Android 8.0.0) and the issue no longer occurs, when an addon is inspected all panels from the toolbox are rendered. I will mark this issue accordingly.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9085395 [details]
Bug 1572793 - Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r?jdescottes!

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1560178#c34.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/b9cf0abb68d5

Comment 12

[Laurentiu Apahidean]

I have tested the issue on the latest Release version 68.2.0 build 2 using a Huawei MediaPad M3 Lite 10 (Android 7.0) and the issue no longer occurs. I will mark this issue accordingly.