Closed Bug 1572793 Opened 4 months ago Closed 3 months ago

Connecting to a webextensions running in a remote Fennec target fails because webextension-fallback.html is missing

Categories

(DevTools :: about:debugging, defect, P1)

defect

Tracking

(firefox-esr60 unaffected, firefox-esr68 verified, firefox68 unaffected, firefox69 verified, firefox70 verified)

VERIFIED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- verified
firefox68 --- unaffected
firefox69 --- verified
firefox70 --- verified

People

(Reporter: rpl, Assigned: rpl)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Connecting from about:debugging to a webextension running in a remote Fennec target is currently failing (the toolbox is actually opened but it fails to be fully initialized) because chrome://devtools/content/shared/webextension-fallback.html doesn't seem to be currently available in a non-desktop build.

This file should be packaged in shared/server, but I didn't see an obvious way to do that, because they seem to use DevtoolsModules in moz.build files instead of jar.mn, and because this isn't a devtools module adding the html file as one seemed wrong. I didn't think it mattered when I wrote the patch, as I figured it's always the client that loads it - but that's wrong, the file is loaded by the devtools server, so the current state of the world is broken when connecting to a fennec server from a desktop client. :-(

Group: firefox-core-security
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/a2688d6a1017
Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Please nominate this for Beta approval when you get a chance.

Flags: qe-verify+
Flags: needinfo?(lgreco)

Comment on attachment 9085395 [details]
Bug 1572793 - Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r?jdescottes!

Beta/Release Uplift Approval Request

  • User impact if declined: Extension developers may be unable to connect a devtools toolbox from about:debugging to a webextension running in a remote Fennec instance (if the Fennec instance with a release version >= 69).
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: - Run a Fennec instance with a release version >= 69 (it may be available from the assets collected from the build infrastructure, I'm not sure if any of the official Fennec/Firefox for Android builds is being build from anything more recent than 68) in an android emulator or test device
  • install an extension on Fennec from AMO
  • enable remove debugging over USB (from Fennec settings)
  • open about:debugging in a recent Nightly Firefox Desktop instance (on the same machine that started the emulator, or the test device over USB)
  • Enable USB devices
  • click the "Connect" button related to the remote Fennec running in the android emulator or test device (once it appears in the about:debugging left sidebar, if it doesn't press the "Refresh devices" button) and once connected click on the entry in the sidebar
  • in the "Extensions" list look for the extension installed from AMO and click the "Inspect" button

Expected behavior:

  • it opens a devtools toolbox connected to the remote extension and the devtools toolbox is correctly rendered and provide all the expected devtools panels
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The fix is pretty small, it moves the fallback.html page into the "devtools shared" resources (which are available in both desktop and mobile builds).
  • String changes made/needed:
Flags: needinfo?(lgreco)
Attachment #9085395 - Flags: approval-mozilla-beta?

Comment on attachment 9085395 [details]
Bug 1572793 - Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r?jdescottes!

Fixes a devtools regression in Fx69. Approved for 69.0b16.

Attachment #9085395 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have tested the issue on the latest Firefox builds: 69.0b16 and 70.0a1 (2019-08-22) using a Samsung Galaxy S8+ (Android 8.0.0) and the issue no longer occurs, when an addon is inspected all panels from the toolbox are rendered. I will mark this issue accordingly.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Comment on attachment 9085395 [details]
Bug 1572793 - Move webextension-fallback.html from devtools/client/jar.mn to devtools/shared/jar.mn. r?jdescottes!

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1560178#c34.

Attachment #9085395 - Flags: approval-mozilla-esr68+

I have tested the issue on the latest Release version 68.2.0 build 2 using a Huawei MediaPad M3 Lite 10 (Android 7.0) and the issue no longer occurs. I will mark this issue accordingly.

QA Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.