Closed Bug 1572802 Opened 3 months ago Closed Last month

The breakpoints pane scrolls horizontally

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: jlast, Assigned: khmorehouse)

References

(Blocks 2 open bugs)

Details

(Keywords: good-first-bug, Whiteboard: [debugger-reserve])

Attachments

(3 files)

When you add a breakpoint with a long snippet, the snippet forces the pane to be too wide and introduces horizontal scrolling.

We should use CSS to truncate the snippet and prevent scrolling.

STR:

  1. go to https://send.firefox.com/
  2. add a breakpoint in app.<sha>.js

http://g.recordit.co/AjleuSHcyk.gif

Keywords: good-first-bug

Can I take this one?

Yes, that would be great!

Assignee: nobody → khmorehouse
Priority: -- → P3

I've come up with a mock solution for this that I'd like some input on:

For starters, here's a look at the current (buggy) behavior, before the solution is in place:

Here's my mock solution, which collapses and expands the watch expressions & breakpoints panels in tandem, so that the breakpoints panel's width cannot be expanded "behind" the watch expressions panel and cause the horizontal scrolling.

Is this the kind of behavior I should try to implement? Or is there an alternative implementation I should aim for?

Flags: needinfo?(jlaster)

That looks great Kevin!

Flags: needinfo?(jlaster)
Status: NEW → ASSIGNED
Whiteboard: [debugger-reserve]

Hello Kevin, how's this going? Anything we can help with?

Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/606f2e3c4850
Prevent unwanted breakpoint scrolling r=jlast
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1588754
You need to log in before you can comment on or make changes to this bug.