1572805 - Use cbindgen for text-emphasis-style

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio) (PTO until Jul 10)]

It's more complex than what it needs to be.

Comment 1

[Emilio Cobos Álvarez (:emilio) (PTO until Jul 10)]

Attachment: Bug 1572805 - Simplify text-emphasis-style.

Comment 2

[Emilio Cobos Álvarez (:emilio) (PTO until Jul 10)]

Attachment: Bug 1572805 - Use cbindgen for text-emphasis-style.

I sent https://github.com/eqrion/cbindgen/pull/377 since I got sick of
copy-pasting the private default constructor stuff :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81b56d76505a
Simplify text-emphasis-style. r=boris,xidorn
https://hg.mozilla.org/integration/autoland/rev/849ca4b3f9de
Use cbindgen for text-emphasis-style. r=boris

Comment 4

[Daniel Varga [:dvarga]]

Backed out 2 changesets (Bug 1572805) for build-rusttests failure.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=260957794&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=849ca4b3f9de609933014881329f51dc897e13b5

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=260957569&repo=autoland&lineNumber=12227

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=43c4b2e58cabba4e532dfa9428b5532e260ee903

[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  running 1 test
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  test visitor.rs - visitor::Visit::visit (line 60) ... ignored
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  test result: ok. 0 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -     Doc-tests malloc_size_of_derive
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -       Running `/builds/worker/workspace/build/src/rustc/bin/rustdoc --test /builds/worker/workspace/build/src/third_party/rust/malloc_size_of_derive/lib.rs --crate-name malloc_size_of_derive -L dependency=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/debug/deps -L native=/builds/worker/workspace/build/src/obj-firefox/debug/build/libloading-9269aaba2a0baecf/out -L dependency=/builds/worker/workspace/build/src/obj-firefox/debug/deps --extern malloc_size_of_derive=/builds/worker/workspace/build/src/obj-firefox/debug/deps/libmalloc_size_of_derive-69830340426525bb.so --extern proc_macro2=/builds/worker/workspace/build/src/obj-firefox/debug/deps/libproc_macro2-7ff1bb8968297905.rlib --extern syn=/builds/worker/workspace/build/src/obj-firefox/debug/deps/libsyn-07a5b7b0f6e0d9d2.rlib --extern synstructure=/builds/worker/workspace/build/src/obj-firefox/debug/deps/libsynstructure-7012f6083c546fa0.rlib`
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  running 0 tests
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  error: test failed, to rerun pass '-p stylo_tests --lib'
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  /builds/worker/workspace/build/src/config/makefiles/rust.mk:280: recipe for target 'force-cargo-test-run' failed
[task 2019-08-10T17:58:19.956Z] 17:58:19    ERROR -  make[1]: *** [force-cargo-test-run] Error 101
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/rust'
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:106: recipe for target 'toolkit/library/rust/rusttests' failed
[task 2019-08-10T17:58:19.956Z] 17:58:19     INFO -  make: *** [toolkit/library/rust/rusttests] Error 2
[task 2019-08-10T17:58:19.972Z] 17:58:19     INFO -  11 compiler warnings present.
[task 2019-08-10T17:58:20.038Z] 17:58:20    ERROR - Return code: 2
[task 2019-08-10T17:58:20.038Z] 17:58:20  WARNING - setting return code to 2
[task 2019-08-10T17:58:20.038Z] 17:58:20    FATAL - 'mach build -v pre-export export recurse_rusttests' did not run successfully. Please check log for errors.
[task 2019-08-10T17:58:20.038Z] 17:58:20    FATAL - Running post_fatal callback...
[task 2019-08-10T17:58:20.038Z] 17:58:20    FATAL - Exiting -1
[task 2019-08-10T17:58:20.038Z] 17:58:20     INFO - [mozharness: 2019-08-10 17:58:20.038898Z] Finished build step (failed)
[task 2019-08-10T17:58:20.038Z] 17:58:20     INFO - Running post-run listener: _parse_build_tests_ccov
[task 2019-08-10T17:58:20.038Z] 17:58:20     INFO - Running post-run listener: _shutdown_sccache
[task 2019-08-10T17:58:20.039Z] 17:58:20     INFO - Running command: ['/builds/worker/workspace/build/src/sccache/sccache', '--stop-server'] in /builds/worker/workspace/build/src

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06c5dcd34b36
Simplify text-emphasis-style. r=boris,xidorn
https://hg.mozilla.org/integration/autoland/rev/f252db10f2e0
Use cbindgen for text-emphasis-style. r=boris

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/743d0d442e0c
Undo last minute serialization change so that I can land it with tests. r=me

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/06c5dcd34b36
https://hg.mozilla.org/mozilla-central/rev/f252db10f2e0
https://hg.mozilla.org/mozilla-central/rev/743d0d442e0c

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bced6e5d6d32
Adjust comment grammar as suggested by xidorn. r=comment-only

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bced6e5d6d32