Closed Bug 1572806 Opened 7 months ago Closed 5 months ago

Fennec Activation Ping - profile_date is empty

Categories

(Firefox for Android :: Metrics, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- wontfix
firefox-esr68 70+ verified
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- verified

People

(Reporter: frank, Assigned: andrei.a.lazar)

References

Details

(Whiteboard: [qa-triaged])

Attachments

(1 file)

Amit and I have been investigating these pings, and discovered this issue as well.

The priority flag is not set for this bug.
:st3fan, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sarentz)

Hi Chris,

do we need to set a priority flag here? Just want to make sure it on the radar.

Flags: needinfo?(cpeterson)

(In reply to arana from comment #2)

do we need to set a priority flag here? Just want to make sure it on the radar.

Yes. I'm marking this bug as P1 since we want to fix it in Fennec ESR 68.x. Thanks for catching the missing priority.

Flags: needinfo?(cpeterson)
Priority: -- → P1
Assignee: nobody → andrei.a.lazar

I understand we are not actually sending this value. Frank, can you describe what this field means and what the datestamp format should be?

Flags: needinfo?(sarentz) → needinfo?(fbertsch)

Sure, this should be the same value as we have in the core ping for profile_date. It is an integer value which represents the number of days since the Epoch, at which point the profile was created.

Doc here: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/core-ping.html

Flags: needinfo?(fbertsch)

Profile creation date (profile_date) is now embedded in Telemetry Activation Ping.

Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b6ae9797451
Added profile_date parameter to Telemetry Activation Ping r=VladBaicu

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Tested on the build provided by Andrei with Google Pixel (Android Q) and I managed to see the profile_date value. I will check also on Monday.

Sounds like this needs an ESR68 approval request?

Flags: needinfo?(andrei.a.lazar)

Comment on attachment 9095201 [details]
Bug 1572806 - Added profile_date parameter to Telemetry Activation Ping r=VladBaicu

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: It is highly required by the Data Science Team.
  • User impact if declined: Data Science Team won't be able to analyze the user's profile creation date.
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change is not risky because it doesn't introduces any new behaviors but rather replaces a missing value with a valid one.
  • String or UUID changes made by this patch:
Flags: needinfo?(andrei.a.lazar)
Attachment #9095201 - Flags: approval-mozilla-esr68?
Flags: qe-verify+

Comment on attachment 9095201 [details]
Bug 1572806 - Added profile_date parameter to Telemetry Activation Ping r=VladBaicu

Fixes a severe Fennec telemetry bug. Approved for Fennec 68.2b7.

Attachment #9095201 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
QA Whiteboard: [qa-triaged]

Tested with Sony Xperia Z5 Premium (Android 7.1.1) on 68.2b7 and the profile_date field was not null. Also, I saw org.mozilla.fennec_aurora entries with the field populated. Marking 68:verified.

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Whiteboard: [qa-triaged]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.