1572806 - Fennec Activation Ping - profile_date is empty

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Metrics, defect, P1)

Description

[Frank Bertsch [:frank]]

Amit and I have been investigating these pings, and discovered this issue as well.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:st3fan, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[arana]

Hi Chris,

do we need to set a priority flag here? Just want to make sure it on the radar.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to arana from comment #2)

do we need to set a priority flag here? Just want to make sure it on the radar.

Yes. I'm marking this bug as P1 since we want to fix it in Fennec ESR 68.x. Thanks for catching the missing priority.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I understand we are not actually sending this value. Frank, can you describe what this field means and what the datestamp format should be?

Comment 5

[Frank Bertsch [:frank]]

Sure, this should be the same value as we have in the core ping for profile_date. It is an integer value which represents the number of days since the Epoch, at which point the profile was created.

Doc here: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/core-ping.html

Comment 6

[Andrei Lazar]

Attachment: Bug 1572806 - Added profile_date parameter to Telemetry Activation Ping r=VladBaicu

Profile creation date (profile_date) is now embedded in Telemetry Activation Ping.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b6ae9797451
Added profile_date parameter to Telemetry Activation Ping r=VladBaicu

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7b6ae9797451

Comment 9

[Andrei Lazar]

Here is the treeherder build with ESR tip: https://treeherder.mozilla.org/#/jobs?repo=try&revision=acf467cc1e32f12dac5ba3ed2c9699b2d422bfeb

Comment 10

[Sorina Florean [:sflorean]]

Tested on the build provided by Andrei with Google Pixel (Android Q) and I managed to see the profile_date value. I will check also on Monday.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Sounds like this needs an ESR68 approval request?

Comment 12

[Andrei Lazar]

Comment on attachment 9095201 [details]
Bug 1572806 - Added profile_date parameter to Telemetry Activation Ping r=VladBaicu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: It is highly required by the Data Science Team.
• User impact if declined: Data Science Team won't be able to analyze the user's profile creation date.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is not risky because it doesn't introduces any new behaviors but rather replaces a missing value with a valid one.
• String or UUID changes made by this patch:

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9095201 [details]
Bug 1572806 - Added profile_date parameter to Telemetry Activation Ping r=VladBaicu

Fixes a severe Fennec telemetry bug. Approved for Fennec 68.2b7.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/f10977a01ff6

Comment 15

[Sorina Florean [:sflorean]]

Tested with Sony Xperia Z5 Premium (Android 7.1.1) on 68.2b7 and the profile_date field was not null. Also, I saw org.mozilla.fennec_aurora entries with the field populated. Marking 68:verified.