1572872 - Return NS_ERROR_NOT_INITIALIZED instead of NS_ERROR_ILLEGAL_VALUE when the message manager isn't initialized

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Andrew McCreight [:mccr8]]

If the mMessageManager field is null, then various message manager functions return NS_ERROR_NULL_POINTER, which gets printed out as NS_ERROR_ILLEGAL_VALUE. When I came across this in bug 1572781, I thought it meant that an invalid argument was being passed in. I think NS_ERROR_NOT_INITIALIZED better reflects that the message manager global isn't actually set up properly. In this particular case, it was actually after it was shutdown instead of before it was initialized, but I think that's close enough.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1572872 - Return NS_ERROR_NOT_INITIALIZED if the message manager isn't initialized.

If the mMessageManager field is null, then various message manager
functions return NS_ERROR_NULL_POINTER, which gets printed out as
NS_ERROR_ILLEGAL_VALUE, which is confusing. NS_ERROR_NOT_INITIALIZED
will better indicate the problem is that that the message manager
itself isn't set up correctly, rather than that the arguments are
invalid.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1815f6ac0dd2
Return NS_ERROR_NOT_INITIALIZED if the message manager isn't initialized. r=smaug

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1815f6ac0dd2